Bugzilla – Full Text Bug Listing
| Summary: | [search] Code assist proposes non accessible types into completion | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Maxime Daniel <maxime_daniel> | ||||||
| Component: | Core | Assignee: | Frederic Fusier <frederic_fusier> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | daniel_megert | ||||||
| Version: | 3.1 | ||||||||
| Target Milestone: | 3.1 RC3 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
The problem occurs only if Taratata is inside the default package The problem is inside BasisSearchEngine#searchAllTypeNames(). The path computed inside the IndexQueryRequestor seems incorrect when record.pkg.length is 0. It is "/Taratata" and should be "Taratata". Created attachment 22903 [details]
Patch to fix this issue
When package pattern is not null but empty, IndexQueryRequestor wrongly adds a
'/' before document path...
Created attachment 22907 [details]
Test cases added to CompletionTests2
+1 for RC3. Dani - would you pls vote for this one ? +1 for 3.1 RC3. Improving code assist is always welcome ;-) Fixed and released in HEAD. Verified using build N20050616-0010 + JDT Core HEAD. |
Build I20050527-0010. One project P1 with class Taratata in src, default package. A second project P2 which has P1 on its buildpath with access rule that forbids access to all. A class in P2 that reads as follows (| figures the insertion point when invoking code assist): public class BreakRules { Tara| } Code assist suggests type Taratata.