Bug 96464

Summary: [assist] JavaCorePreferenceInitializer does not initialized CODEASSIST_DISCOURAGED_REFERENCE_CHECK
Product: [Eclipse Project] JDT Reporter: Tom Hofmann <eclipse>
Component: CoreAssignee: David Audel <david_audel>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: markus.kell.r
Version: 3.1   
Target Milestone: 3.1 RC1   
Hardware: PC   
OS: All   
Whiteboard:

Description Tom Hofmann CLA 2005-05-24 13:16:40 EDT 
N20050524

David, I guess JavaCorePreferenceInitializer.initializeDefaultPreferences should
also initialize CODEASSIST_DISCOURAGED_REFERENCE_CHECK - it currently
initializes CODEASSIST_FORBIDDEN_REFERENCE_CHECK twice.
Comment 1 David Audel CLA 2005-05-24 13:28:05 EDT 
That's right

Fixed.
Comment 2 David Audel CLA 2005-05-25 09:14:57 EDT 
I made the same error inside AssistOptions#set(Map optionsMap)

This code 

if ((optionValue = optionsMap.get(OPTION_OPTION_PerformForbiddenReferenceCheck))
!= null) {
	if (ENABLED.equals(optionValue)) {
		this.checkDiscouragedReference = true;
	} else if (DISABLED.equals(optionValue)) {
		this.checkDiscouragedReference = false;
	}
}

must be

if ((optionValue = optionsMap.get(OPTION_PerformDiscouragedReferenceCheck)) !=
null) {
	if (ENABLED.equals(optionValue)) {
		this.checkDiscouragedReference = true;
	} else if (DISABLED.equals(optionValue)) {
		this.checkDiscouragedReference = false;
	}
}

Fixed.
Comment 3 Maxime Daniel CLA 2005-05-27 07:35:08 EDT 
Verified on build I20050527-0010.