Bug 94914

Summary: DBCS3.2: Incorrect Compare result for Linux UTF-8 CVS server
Product: [Eclipse Project] Platform Reporter: Masayuki Fuse <fuse>
Component: CVSAssignee: Bogdan Gheorghe <gheorghe>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P2 CC: camle, Karice_McIntyre, kitlo, steven.wasleski
Version: 3.2   
Target Milestone: 3.2 RC1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
screen shot
none
sample UTF-8 encoded project
none
screenshot on Eclipse 3.2M6
none
screenshot on Eclipse M6 part-2
none
Patched org.eclipse.team.ui_3_0_1 plugin
none
Updated org.eclipse.team.ui_3_0_1 plugin none

Description Masayuki Fuse CLA 2005-05-12 05:23:01 EDT
Driver : Eclipse 3.1 I20050509-2010 on WindowsXP Japanese sp2
JVM : IBM 1.4.2 SR1a
CVS Server : cvs 1.11.17 on RHEL4 WS ja_JP.UTF-8 locale

Steps
1. create new CVS server repository connection for UTF-8 encoded cvs on RHEL4
2. change the Server encoding to UTF-8 from default (MS932) at the Properties
3. Check out a Java project
3. At Java Perspective, change the Java project file encoding to UTF-8 from 
default MS932
4. edit edit a java program and save it
5. Select Compare With > Latest from HEAD at the context menu

Result
All of DBCS text at Remote file view are garbled. I will attache the screenshot
Comment 1 Masayuki Fuse CLA 2005-05-12 05:26:51 EDT
Created attachment 21032 [details]
screen shot
Comment 2 Masayuki Fuse CLA 2005-05-12 05:30:48 EDT
Created attachment 21033 [details]
sample UTF-8 encoded project
Comment 3 Michael Valenta CLA 2005-05-12 09:03:45 EDT

*** This bug has been marked as a duplicate of 72995 ***
Comment 4 Masayuki Fuse CLA 2006-04-03 07:19:58 EDT
fixed partially in M6.
Comment 5 Masayuki Fuse CLA 2006-04-03 07:24:21 EDT
Created attachment 37505 [details]
screenshot on Eclipse 3.2M6

string at java Structure Compare is bogus
Comment 6 Masayuki Fuse CLA 2006-04-03 07:27:17 EDT
Created attachment 37506 [details]
screenshot on Eclipse M6 part-2

clicking the element of Java Structure Compare makes bogus remote file
Comment 7 Bogdan Gheorghe CLA 2006-04-04 19:29:54 EDT
Fixed in HEAD. While creating the input for the compare editor, the encoding wasn't being set for the remote file. We've put a fix in to use the same encoding on the remote element that's being used for the local file.
Comment 8 Michael Valenta CLA 2006-04-06 09:39:20 EDT
Created attachment 37875 [details]
Patched org.eclipse.team.ui_3_0_1 plugin

I am attaching a patched version of the org.eclipse.team.ui_3_0_1 plugin with a fix for this problem. It can be placed in the plugins directory of any eclipse 3.0.2 install. The only change is in the teamui.jar that is contained in the zip.
Comment 9 Michael Valenta CLA 2006-04-07 10:32:02 EDT
Created attachment 37991 [details]
Updated org.eclipse.team.ui_3_0_1 plugin

I've updated the attached plugin to always use the local encoding
Comment 10 Masayuki Fuse CLA 2006-04-17 05:17:07 EDT
verified in RC1. closing. Thanks.