Bug 93727

Summary:

Code Formatter fails with Method Parameter Annotations

Product:

[Eclipse Project] JDT

Reporter:

Geoffrey Wiseman <geoffrey.wiseman>

Component:

Core

Assignee:

Olivier Thomann <Olivier_Thomann>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

Version:

3.1

Target Milestone:

3.1 M7

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Apply on HEAD on CodeFormatterVisitor	none
Apply on HEAD on org.eclipse.jdt.core.tests.model	none

Description Geoffrey Wiseman

2005-05-04 17:43:55 EDT

The eclipse code formatter doesn't seem to work when you have methods with
parameter annotations.  It fails silently, and I don't see an error in
<Workspace>/.metadata/.log.

Example:
import org.drools.semantics.annotation.DroolsParameter;

public class Test
{
  public Object passthrough( @DroolsParameter("parameter") Object parameter ) {
    return parameter;
  }
}

Comment 1 Tom Hofmann

2005-05-05 04:56:33 EDT

moving to core

Comment 2 Olivier Thomann

2005-05-11 15:14:52 EDT

Now we would format like this:

public class Test
{
  public Object passthrough(@DroolsParameter("parameter")
  Object parameter ) {
    return parameter;
  }
}

The default option is to add a new line after an annotation.

Comment 3 Olivier Thomann

2005-05-11 15:17:12 EDT

Created attachment 21001 [details]
Apply on HEAD on CodeFormatterVisitor

Comment 4 Olivier Thomann

2005-05-11 15:18:39 EDT

Created attachment 21002 [details]
Apply on HEAD on org.eclipse.jdt.core.tests.model

Corresponding regression test

Comment 5 Olivier Thomann

2005-05-11 22:45:34 EDT

Fixed and released in HEAD.
Regression test added in
org.eclipse.jdt.core.tests.formatter.FormatterRegressionTests.test575.

Comment 6 David Audel

2005-05-12 13:41:41 EDT

Verified in N200505120010