Summary: | ASTParser#createASTs(..) does not use the given progress monitor | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Markus Keller <markus.kell.r> |
Component: | Core | Assignee: | Jerome Lanneluc <jerome_lanneluc> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | ||
Version: | 3.1 | ||
Target Milestone: | 3.1 M7 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: | |||
Bug Depends on: | |||
Bug Blocks: | 89537 |
Description
Markus Keller
2005-03-15 12:21:16 EST
3.0.1 with v_541!? I guess you wanted to say 3.1 for version... Oops, 3.1 of course. I'm running with 3.0.2 RC2 as host eclipse and I forgot to switch bugzilla back to 3.1 after having filed a 3.0.1 bug... Jerome, can we do something here for M7. We really show bad progress reporting in refactorings the use the AST pipeline. Changed CompilationUnitResolver#resolved(ICompilationUnit[],String[],ASTRequestor,int,Map,IJavaProject,WorkingCopyOwner,IProgressMonitor) and CompilationUnitResolver#parse(ICompilationUnit[],ASTRequestor,int,Map,IProgressMonitor) to report progress to the given progress monitor (and also checking cancel on this progress monitor). Progress reporting still does not work in N20050503-0010. I could make it work by removing a SubProgressMonitor in CompilationUnitResolver. I simply replaced line 444 of rev. 1.104 by this line: IProgressMonitor subProgressMonitor = monitor; I should have asked this before: can you please provide a test case ? I should have provided the test case before ;-): - import org.junit as source - set compiler compliance to 5.0 and link a 1.5 JRE - on the project, run Refactor > Infer Type Arguments Thanks Markus. Changed CompilationUnitResolver#resolve(...) and parse(...) to not use a SubProgressMonitor. Also improved handling of OperationCanceledException. Verified for 3.1 M7 using build I20050509-2010 + jdt.core HEAD. |