Bugzilla – Full Text Bug Listing
| Summary: | [AST] SimpleName.setIdentifier() not detecting bogus identifiers | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Jim des Rivieres <jeem> |
| Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Olivier_Thomann |
| Version: | 3.0 | ||
| Target Milestone: | 3.1 M6 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
I guess I don't check that there is just one identifier. Fixed and released in HEAD. Regression test updated in ASTTest.testSimpleName() Verified in 20050330-0500 |
Build 3.1 M5a SimpleName.setIdentifier() is letting through some bogus Java identifiers which it should be rejecting. I've beefed up ASTTest.testSimpleName() to include some bogus identifiers. Here's a log that shows the problem: Error: SimpleName.setIdentifier("a b") was not rejected Error: SimpleName.setIdentifier("a ") was not rejected SimpleName.setIdentifier(" a") was rejected Error: SimpleName.setIdentifier("a-b") was not rejected Error: SimpleName.setIdentifier("a[]") was not rejected Error: SimpleName.setIdentifier("a<T>") was not rejected SimpleName.setIdentifier("") was rejected SimpleName.setIdentifier(" ") was rejected Error: SimpleName.setIdentifier("a.b") was not rejected Once the problem is fixed, remove the print statements from the test and reinstate the commented out "assertTrue(false)".