Summary: | [assist] CompletionProposal.getDeclarationSignature returns null for array types | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Tom Hofmann <eclipse> |
Component: | Core | Assignee: | David Audel <david_audel> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | ||
Version: | 3.1 | ||
Target Milestone: | 3.1 M7 | ||
Hardware: | PC | ||
OS: | All | ||
Whiteboard: |
Description
Tom Hofmann
2005-02-08 09:59:28 EST
For an array object the only proposals without 'declaration signature' are the FIELD_REF 'length' and the METHOD_REF 'clone' and they are not defined inside Object. I can return: null (as now) or Ljava.lang.Object; (Object is not really the declaring type) or [Ljava.lang.Object; or [RealTypeSignature (RealTypeSignature could be a base type) sorry for not replying earlier... > For an array object the only proposals without 'declaration signature' are the > FIELD_REF 'length' and the METHOD_REF 'clone' and they are not defined inside > Object. > > I can return: > null (as now) -1 as comment 0 says, I believe this is unexpected. > or Ljava.lang.Object; (Object is not really the declaring type) -1 as this would be simply not true. > or [Ljava.lang.Object; ok - albeit this could be interpreted to imply that the declaring type is an Object[] > or [RealTypeSignature (RealTypeSignature could be a base type) I like this one best, because this is the correct answer to the question "which types declares the field 'length'?" Fixed and tests added CompletionTests#testArrayLength() CompletionTests#testArrayClone() Verified in I20050510-0010 + JDT/Core v_556 |