Summary: | Not visiting line comments in compilation unit? | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | DJ Houghton <dj.houghton> |
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> |
Status: | VERIFIED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | jeem |
Version: | 3.0 | ||
Target Milestone: | 3.1 M5 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
DJ Houghton
2005-02-06 12:36:14 EST
Comments are not visited. The only comments that are visited are the javadoc comment attached to a declaration. Closing as INVALID. Should the javadoc be updated for ASTVisitor.visit(LineComment) saying that it won't be called? Reopen to update javadoc. Would this clarify the specs? <p>Note that {@link #visit(LineComment) ASTVisitor.visit(LineComment)} and * {@link #visit(BlockComment) ASTVisitor.visit(BlockComment)} are never traversed. * The user needs to use the {@link org.eclipse.jdt.core.dom.CompilationUnit#getCommentList() CompilationUnit.getCommentList()} * to traverse all the comments in the compilation unit. * </p> That would be good on the class comment. And it would be useful to have on the methods themselves: Note: this method is old API and is never called or something to that effect. That way it would show up in the hover when client do code assist, etc. Ok, done. Spec has been clarified. Fixed and released in HEAD. Hey. This is *not* old API. And the methods certainly can be called (although just not part of a normal AST traversal). I've change the spec's to clarify that situation. And the corresponding methods on ASTMatcher as well. Verified in I20050215-2300 |