Bug 7821

Summary: Team 2.0 CVS synchronze bug <no-name> dirs..
Product: [Eclipse Project] Platform Reporter: Johan Compagner <jcompagner>
Component: CompareAssignee: Andre Weinand <andre_weinand>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P1    
Version: 2.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
the image with <no-name> none

Description Johan Compagner CLA 2002-01-17 04:42:09 EST 
When ever i do a sync with the build 20010115 i get <no-name> for every 
directory. 
I have downloaded the missing icons as far as i know.
Comment 1 Johan Compagner CLA 2002-01-17 04:42:51 EST 
Created attachment 231 [details]
the image with <no-name>
Comment 2 James Moody CLA 2002-01-17 10:56:22 EST 
Hmm. After some investigation, it turns out that this is brought about by 
switching from I20020109 to I20020115, without any changes to the team 
codebase. Suspect something changed in the compare framework. Will investigate, 
thanks for the bug report.
Comment 3 James Moody CLA 2002-01-17 15:37:23 EST 
This is due to changes in the compare framework. The DiffTreeViewer installs a 
label provider which does the following:

if (element instanceof DiffNode)
   return ((DiffNode)element).internalGetName(fLeftIsLocal);

I override DiffNode.getName(), but I can't override DiffNode.internalGetName(), 
which is default visibility. Because I can't override it, the default one is 
called, and it doesn't work because I have a specialized implementation. I 
think the isLeft flag should be added to a public API, or the internalGetName 
should be made protected.

I have a local hack to fix this behaviour for the time being, but I'd prefer to 
take it out. Assigning to Compare.

Released fix to HEAD, thanks for the bug report.
Comment 4 Andre Weinand CLA 2002-01-21 10:04:21 EST 
fixed for 20020122. Overriding getName should work fine now.