Summary: | Create a jar file that can be used for load-time weaving... | ||
---|---|---|---|
Product: | [Tools] AspectJ | Reporter: | Adrian Colyer <adrian.colyer> |
Component: | Compiler | Assignee: | Adrian Colyer <adrian.colyer> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | wes |
Version: | 1.2.1 | ||
Target Milestone: | 1.2.1 | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: |
Description
Adrian Colyer
2004-09-07 10:13:16 EDT
Just my comments: 1) Why not, if the work has already been done, and somebody may find that usefull 2) Why not call it aspectjltw.jar (Load Time Weaving) instead of aspectjwt.jar? Or for what abreviation does wt stand for? 3) Packaging it in the standard distribution is fine IMHO. 4) Having only one extra file, which contains everything I need for the ajc compiler is IMHO agreat plus. Cheers Arno Yay! (finally?) 1) yes, but 2) I'd prefer the jar target all in-process weaving, one of which is ltw (others include IDE extensions, etc.), i.e., just the weaver -- henace "aspectj-weaver.jar"? 3) {aspectj}/lib dir is fine, though I still think there should be a main class that does the launch - j4 -jar aspectj-weaver.jar {normal java command line}. I had this at one point and don't recall the objection. 4) Agreed on not stripping aspectjtools.jar until at least a major release. Also should consider a harness step for ltw just using this jar. otw, I'd be interested in seeing the build script. It *should* just involve building the weaver module with all antecedants (i.e., and require no custom/wrapper task for fixup) and aliasing in the output, but... Fix checked in to build aspectjweaver.jar. This uses the horrible custom/wrapper task for fixup (in the style of aspectjtools.jar). Both of these hacks should be cleaned up in the build script, but I didn't want to hold up 1.2.1 while we do it. The aj script has been updated to use aspectjweaver.jar in its classpath, as has the tracing-lt example in docs/examples. forgot to mark as target 1.2.1... |