Summary: | Numerous bugs reported by FindBugs (http://findbugs.sourceforge.net/) in AspectJ jars | ||
---|---|---|---|
Product: | [Tools] AspectJ | Reporter: | Hristo Stoyanov <hr_stoyanov> |
Component: | Compiler | Assignee: | Adrian Colyer <adrian.colyer> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | aclement, vb |
Version: | 1.2 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Hristo Stoyanov
2004-08-15 02:01:57 EDT
give it a go for 1.6.0 final Although I am not the reporter of this "bug" this my my favorite one. Could you please be so kind and post some results? E.g. bugs reported by findbugs, really bugs etc. Thank you very much. Hi Vincenz, The reason the target changed from 1.6.0 to --- is because I haven't had time to look at it at all and am afraid I won't get to it in the 1.6.0 timeframe... Sorry, I read it the other way around. My fault. But it would really be nice to have some information on this topic, regardless when it will be done. Finally I did some of this, running findBugs over components I was interested in (weaver/new bcel). Interesting findings indeed... a few places where we intended to override equals() and hashCode() but had spelt hashCode() wrong (yikes!) I also turned up the eclipse warnings for: unused code, unnecessary casts and unnecessary conditional checks. There were a slew of these all over the place and I've gotten rid of a lot of them. I also installed PMD, just so I could use the 'find duplicate code' option, and discovered a few places with duplication, including a case where someone had ignored the Abstract implementation of a pattern visitor interface and proceeded to write their own duplicate of what was in the abstract impl. Codebase is improving - i think it may even be weaving faster than before. Weaver is another 20k slimmer. |