Summary: | [NPE] An internal error occurred during: "Override indicator installation job". | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Dan Kehn <kehn> | ||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
Status: | RESOLVED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | philippe_mulet | ||||
Version: | 3.0 | ||||||
Target Milestone: | 3.0.1 | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
Whiteboard: | |||||||
Attachments: |
|
Description
Dan Kehn
2004-07-01 12:28:54 EDT
Would you have a test case to reproduce? Sorry, I don't a step-by-step recreation steps. It occurred after importing some external plug-ins and restarting. Next time I will save the workspace for later diagnosis. This might be a concurrency issue. Reopen. Jim, I don't think that setting the properties is thread-safe. Is it possible that the static initializer is called in two different threads? I see the problem. The static file tempPDL is declared in ASTNode. This means that there is conflict if more than one ASTNode subclass is being initialized at the same time. Created attachment 12988 [details]
jdt.core patch
This problem can show up whenever several threads are triggering AST node class initializations simultaneously. I reworked AST node static initializers to no longer use a static variable in ASTNode. Released to HEAD (3.1). Updated build notes. Philippe, This is a candidate fix for inclusion in 3.0.1. (Attached patch makes it easy to apply to 3.0.1 if needed.) Fine by me. Olivier please review the change and release it if ok. Reopening until addressed in 3.0.1 stream. The patch looks good. Now each node has its own list. Fixed and released in 3_0_maintenance stream. Verified for 3.0.1 RC1 |