Bug 67803

Summary:	Remove dependency of Compare on "ide" plugins for RCP
Product:	[Eclipse Project] Platform	Reporter:	Eleonora Ludin <eludin>
Component:	Compare	Assignee:	Platform-Compare-Inbox <platform-compare-inbox>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	alexander.fedorov, jeffmcaffer, Michal.Tkacz, pwebster
Version:	3.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Eleonora Ludin

2004-06-18 09:18:04 EDT

We would like to use the Compare Editor in our RCP-based application. We are 
able to do it, however, we have to add the following plugins to our RCP 
configuration: org.eclipse.core.resources and org.eclipse.ui.ide. Although 
including these plugins does not seem to affect the UI of our application in 
any way, it seems like these dependencies are not really necessary.

It appears that dependency of the "compare" plugin on the "resources" plugin 
results from the fact that the ResourceNode class is part of the "compare" 
plugin. Perhaps it could be moved somewhere else.

It also appears that dependency on the "ui.ide" plugin is the side-effect of 
CompareEditor.doSave() using WorkspaceModifyOperation to wrap 
CompareEditorInput.saveChanges() call. Perhaps you could leave it up to the 
clients of the doSave() method to write the wrapper if they care about 
Workspace modifications?

Comment 1 Michael Valenta

2007-04-18 21:18:06 EDT

We didn't have time to address this in 3.3.

Comment 2 Tomasz Zarna

2011-02-28 06:51:27 EST

*** Bug 338345 has been marked as a duplicate of this bug. ***

Comment 3 Lars Vogel

2019-09-24 13:57:01 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 4 Alexander Fedorov

2019-09-27 02:15:51 EDT

The problem is deeper and still actual. A lot of very useful Eclipse functionality is IResource-centric, and Compare is a good example of it.

1) "org.eclipse.core.resources" is not something we can rework in this life, however we can think about more transparent support for external paths. This task appears quite often in the RCPs as people would like to just open a file from any location and get all the Eclipse services available for it.

2) "org.eclipse.ui.ide" looks more discussible. I would suggest to extract more neutral JFace-based E4-friendly layer to represent IResource in UI. Just to make it easier for RCPs to utilize it with less unwanted dependencies.

With these two super-tasks resolved we can provide even more "richness" for our Rich Client Platform.