Bug 61998

Summary:

bad idea to subclass Error for ordinary exceptions

Product:

[Eclipse Project] Platform

Reporter:

Jim des Rivieres <jeem>

Component:

Compare

Assignee:

Andre Weinand <andre_weinand>

Status:

VERIFIED FIXED

QA Contact:

Severity:

trivial

Priority:

Version:

3.0

Target Milestone:

3.0 RC2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch to o.e.compare to convert Error to RuntimeException	none

Description Jim des Rivieres

2004-05-12 16:22:52 EDT

Build I20040512

It's generally a bad idea to subclass Error for ordinary exceptions. Better to 
subclass RuntimeException if you want an unchecked exception. 
org.eclipse.compare.internal.ViewerSwitchingCancelled is a subclass of Error; 
it looks to me like it should be a RuntimeException.

Comment 1 Jim des Rivieres

2004-05-12 16:23:43 EDT

Created attachment 10569 [details]
patch to o.e.compare to convert Error to RuntimeException

Patch is totally untested.

Comment 2 Andre Weinand

2004-06-02 18:51:48 EDT

fixed for RC2

Comment 3 Martin Aeschlimann

2004-06-11 05:23:39 EDT

verified that fix is in I20040611 (verified in code)