Summary: | Version the BCEL libraries to allow graceful failure when the wrong version is found. | ||
---|---|---|---|
Product: | [Tools] AspectJ | Reporter: | Andrew Clement <aclement> |
Component: | Compiler | Assignee: | Adrian Colyer <adrian.colyer> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | brendan.mckenna, mert.nuhoglu, udittmer |
Version: | 1.2 | ||
Target Milestone: | 1.2.1 | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Whiteboard: |
Description
Andrew Clement
2004-05-07 08:45:15 EDT
Or we could rename the packages for the version of BCEL that we use to prevent future clashes. *** Bug 59921 has been marked as a duplicate of this bug. *** *** Bug 66222 has been marked as a duplicate of this bug. *** Ideally need to do something here for the 1.2.1 release. Fixed. I have modified the bcel-builder project and introduced two new targets: transformToAJ - changes the package structure from org.apache to org.aspectj.apache transformFromAJ - changes the package structure from org.aspectj.apache to org.aspectj I didn't do any bytecode transformation to achieve this as I realised I wanted to have a valid src.zip that matched the transformed bytecode. So I just used ANT. A mapper to do the renaming of files and introduce the extra level of package naming and then a <replaceregexp> task call to transform references inside all the source files. We store our changes to BCEL in a patch.txt file. This file is still a patch against the non-renamed bcel source. So the order of operations when building a new version of BCEL is: - Extract bcel5.1 into a folder - Patch that bcel - Transform the package names - Package up the transformed code You *can* then work on the transformed code, if you make a fix then you will run the 'diff' target on build.xml to create a new version of the patch, that works as follows: - Transform the package names back - Diff the source with the original BCEL source to create patch.txt This works really well ! The new names for BCEL classes resulted in a ton of changes in the weaver (import statements). Waiting for build before closing. Fixed version available: BUILD COMPLETE - build.339 Date of build: 08/12/2004 09:42:49 Time to build: 92 minutes 32 seconds Last changed: 08/12/2004 09:01:04 Last log entry: BCEL rename (enhancement 61374) Latest good AspectJ jar available at: download.eclipse.org/technology/ajdt/dev/aspectj-DEVELOPMENT.jar *** Bug 75071 has been marked as a duplicate of this bug. *** Fix released as part of AspectJ 1.2.1 |