Bugzilla – Full Text Bug Listing
| Summary: | NPE updating an aspect in incremental mode | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Tools] AspectJ | Reporter: | Wes Isberg <wes> | ||||
| Component: | Compiler | Assignee: | Jim Hugunin <jim-aj> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | major | ||||||
| Priority: | P2 | CC: | christian | ||||
| Version: | 1.2 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 9930 [details]
patch fix
minimal, also adds warning guard, passes test suite. But I don't like this
code ...
raising priority to fix before 1.2 final Adrian fixed. |
NPE when updating an aspect in incremental mode. Find test case in incremental/full-rebuild. AjBuildManager.java:208 finally clause runs after every iteration: ret = !handler.hasErrors(); handler = null; But at AjBuildManager.java:124, handler is only set if there is not a complete rebuild: if (!canIncremental && !batch) { // retry as batch? return doBuild(buildConfig, baseHandler, true); } this.handler = ... Since result is set by return doBuild..), could say if (null != handler) { ret = !handler.hasErrors(); } (Seems to have been introduced in a month ago in 1.44. Our test coverage of incremental mode is awful.)