Bug 582091

Summary:	Wrong figure auto-size layout of RegionContainer and layout of Region contents
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Diagram	Assignee:	Maxime Porhel <maxime.porhel>
Status:	ASSIGNED ---	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	triaged
Version:	unspecified
Target Milestone:	7.2.1
Hardware:	PC
OS:	Mac OS X
Whiteboard:
Bug Depends on:	582089
Bug Blocks:	582090

Description Maxime Porhel

2023-06-20 04:53:53 EDT

+++ This bug was initially created as a clone of Bug #582089 +++

Steps to reproduce: 
* With 
  * Sirius 7.0.x or 7.1.x
  * With BPMN Designer (https://github.com/ObeoNetwork/BPMN-Designer)
  * Import the Travel Agency sample
* Case #1
  * Create a Collaboration diagram
  * Select the tool "Participant et un processus existant"
  * Single click on the diagram 
  * Select "Travel Agency" in the wizard.
  * Layout "KO" :
    * Region content is centered, 
    * RegionContainer notation node is in auto-size but but figure has the default dimension
    * Layout is not stable (Figure are well auto-sized) after a close/reopen diagram (or addition of a new child in the Region)
* Case #2
  * From previous diagram
  * Select the particpant, unset its process from the properties views
  * Check that the participant is in auto-size and emtpy on the diagram
  * Layout "KO" :
    * RegionContainer notation node is in auto-size but but figure has the default dimension
    * Layout is not stable (Figure are well auto-sized) after a close/reopen diagram (or addition of a new child in the Region)
* Case #3
  * Create a new Collaboration diagram
  * Layout OK: Participant is created with Region content layouted, RegionContainer layout is stable and correctly auto-sized.
* Case #4
  * From any previous case, 
  * Move nodes inside the region to right or bottom
  * Scroll bars appears
  * Close and reopen the diagram : no more scrollbars and figure are correctly resized.
  * Layout KO: in auto-size, the RegionContainer should adapt its size to the Region contents.

Comment 1 Maxime Porhel

2023-06-20 04:55:32 EDT

Three proposed fixes for 7.0.x and 7.1.x - disabled by default but can be activated with system properties

See details on Bug 582089

For the moment te exact same fixes are cherry-picked on master. 
But we might decide later to go further.

Comment 2 Maxime Porhel

2023-06-20 04:59:00 EDT

Three proposed fixes for 7.0.x and 7.1.x - disabled by default but can be activated with system properties

See details on Bug 582089

For the moment te exact same fixes are cherry-picked on master. 
But we might decide later to go further.

Comment 3 Maxime Porhel

2023-06-20 04:59:19 EDT

- https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/202620 [582091] Do not apply center layout on Region content at creation time [NEW]

- https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/202621 [582091] Use model constraint to layout Regions [NEW]

- https://git.eclipse.org/r/c/sirius/org.eclipse.sirius/+/202622 [582091] Enable individual auto-size action and status for Regions [NEW]