Bug 579483

Summary:

Flickering when invoking keyboard shortcuts with ambiguous commands

Product:

[Eclipse Project] Platform

Reporter:

Dirk Steinkamp <Dirk.Steinkamp>

Component:

Assignee:

Platform-UI-Inbox <Platform-UI-Inbox>

Status:

NEW ---

QA Contact:

Severity:

major

Priority:

CC:

digga1404, javarno, loskutov

Version:

4.23

Keywords:

needinfo

Target Milestone:

---

Hardware:

OS:

Windows 10

Whiteboard:

Attachments:

Description	Flags
Animated GIF with flickering effect	none

Description Dirk Steinkamp

2022-03-29 12:59:22 EDT

As reported here: https://github.com/projectlombok/lombok/issues/3134#issuecomment-1081170808

there seems to be an issue with "flickering" if you have two commands associated to the same keyboard shortcuts.
Illustrated here: https://user-images.githubusercontent.com/18091406/160502083-a1576f9d-9bc0-4821-b57b-b3193057fd4d.png

I had the same with different commands, so I realized it looks be a platform problem.

Comment 1 Dominik G.

2022-03-31 05:06:04 EDT

Created attachment 288351 [details]
Animated GIF with flickering effect

Same on my installation: Windows 10 21H2 - eclipse 4.23. 
The flickering tooks up to 10 seconds. Sometime the shortcut dialog pops up, sometimes not.
It looks like the popup dialog, the workbench window itself and the main menu try to get the focus alternately.
At that time the eclipse application window gains and loses the focus about 50! times. 
Unfortunately, the animated GIF does not show the actual flickering speed. The flickering is certainly 10 times faster.

Comment 2 Andrey Loskutov

2022-03-31 11:14:27 EDT

AFAIK lombok is brolen on 4.23 and needs an update. I assume this flickering is only there if you have lombok installed?

Comment 3 Dirk Steinkamp

2022-03-31 12:28:09 EDT

(In reply to Andrey Loskutov from comment #2)
> AFAIK lombok is brolen on 4.23 and needs an update. I assume this flickering
> is only there if you have lombok installed?

no, it's does not seem to be related to lombok. I had it in a different context with different commands.

Comment 4 Andrey Loskutov

2022-03-31 12:34:26 EDT

(In reply to Dirk Steinkamp from comment #3)
> (In reply to Andrey Loskutov from comment #2)
> > AFAIK lombok is brolen on 4.23 and needs an update. I assume this flickering
> > is only there if you have lombok installed?
> 
> no, it's does not seem to be related to lombok. I had it in a different
> context with different commands.

If lombok was installed, this is irrelevant, if lombok patches platform code.
Please uninstall & check.

Comment 5 Dirk Steinkamp

2022-03-31 13:36:11 EDT

(In reply to Andrey Loskutov from comment #4)
> (In reply to Dirk Steinkamp from comment #3)
> > (In reply to Andrey Loskutov from comment #2)
> > > AFAIK lombok is brolen on 4.23 and needs an update. I assume this flickering
> > > is only there if you have lombok installed?
> > 
> > no, it's does not seem to be related to lombok. I had it in a different
> > context with different commands.
> 
> If lombok was installed, this is irrelevant, if lombok patches platform code.
> Please uninstall & check.

I checked: it's not related to lombok (and I used the snapshot that should include a fix anyhow). I was not 100% sure in which installation the flickering occured, but I made sure to uninstall it and tried again.
This is the build I have tried it against: eclipse-platform-I20220324-1800-win32-x86_64, but it seems to be introduced in 4.23.

The root condition seems to be "two commands associated to the same keyboard shortcuts".