Bug 578743

Summary:	Sleak (SWT tools) view is empty and destroys workbench on shutdown
Product:	[Eclipse Project] Platform	Reporter:	Rolf Theunissen <rolf.theunissen>
Component:	SWT	Assignee:	Andrey Loskutov <loskutov>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	Lars.Vogel, loskutov
Version:	4.22	Keywords:	regression
Target Milestone:	4.24 M3
Hardware:	PC
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=577275 https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/190807 https://bugs.eclipse.org/bugs/show_bug.cgi?id=437558 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=64643a9248b0ccff6efb86c7f4412692f7391354
Whiteboard:
Bug Depends on:	577462
Bug Blocks:

Description Rolf Theunissen

2022-02-14 11:03:41 EST

Try opening the Sleak view, the resulting view appears to be empty.

Adding a new GridLayout(2, false) to the containing composite does show the controls.
Moreover, the Sleak view is not closable. Also with the view open the workbench model is broken on re-start, resetting to the default window.

Comment 1 Andrey Loskutov

2022-02-14 12:46:38 EST

(In reply to Rolf Theunissen from comment #0)
> Try opening the Sleak view, the resulting view appears to be empty.
> 
> Adding a new GridLayout(2, false) to the containing composite does show the
> controls.
> Moreover, the Sleak view is not closable. Also with the view open the
> workbench model is broken on re-start, resetting to the default window.

Sounds like the bug Lars had with PDE Spy tools.

Lars?

Comment 2 Andrey Loskutov

2022-02-15 03:52:25 EST

(In reply to Rolf Theunissen from comment #0)
> Moreover, the Sleak view is not closable. Also with the view open the
> workbench model is broken on re-start, resetting to the default window.

Damn, I've not noticed that, and it destroyed my workbench *once again* (see bug 577275)!!!


org.eclipse.emf.ecore.resource.impl.ResourceSetImpl$1DiagnosticWrappedException: org.eclipse.emf.ecore.xmi.UnresolvedReferenceException: Unresolved reference '_0T0XoI29EeyaSfjHvloQPQ'. (file:/data/4x_platform_workspace/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi, 380, 183)
	at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.handleDemandLoadException(ResourceSetImpl.java:319)
	at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoadHelper(ResourceSetImpl.java:278)
	at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.getResource(ResourceSetImpl.java:406)
	at org.eclipse.e4.ui.internal.workbench.ResourceHandler.getResource(ResourceHandler.java:290)
	at org.eclipse.e4.ui.internal.workbench.ResourceHandler.loadResource(ResourceHandler.java:266)
	at org.eclipse.e4.ui.internal.workbench.ResourceHandler.loadMostRecentModel(ResourceHandler.java:169)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Application.loadApplicationModel(E4Application.java:371)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Application.createE4Workbench(E4Application.java:247)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:573)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:551)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:156)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:136)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:596)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1467)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1440)
Caused by: org.eclipse.emf.ecore.xmi.UnresolvedReferenceException: Unresolved reference '_0T0XoI29EeyaSfjHvloQPQ'. (file:/data/4x_platform_workspace/.metadata/.plugins/org.eclipse.e4.workbench/workbench.xmi, 380, 183)
	at org.eclipse.emf.ecore.xmi.impl.XMLHandler.handleForwardReferences(XMLHandler.java:1197)
	at org.eclipse.emf.ecore.xmi.impl.XMLHandler.endDocument(XMLHandler.java:1282)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.endDocument(AbstractSAXParser.java:746)
	at java.xml/com.sun.org.apache.xerces.internal.impl.XMLDocumentFragmentScannerImpl.scanDocument(XMLDocumentFragmentScannerImpl.java:539)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:888)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:824)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:141)
	at java.xml/com.sun.org.apache.xerces.internal.parsers.AbstractSAXParser.parse(AbstractSAXParser.java:1216)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl$JAXPSAXParser.parse(SAXParserImpl.java:635)
	at java.xml/com.sun.org.apache.xerces.internal.jaxp.SAXParserImpl.parse(SAXParserImpl.java:324)
	at org.eclipse.emf.ecore.xmi.impl.XMLLoadImpl.load(XMLLoadImpl.java:175)
	at org.eclipse.emf.ecore.xmi.impl.XMLResourceImpl.doLoad(XMLResourceImpl.java:261)
	at org.eclipse.emf.ecore.resource.impl.ResourceImpl.load(ResourceImpl.java:1563)
	at org.eclipse.emf.ecore.resource.impl.ResourceImpl.load(ResourceImpl.java:1342)
	at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoad(ResourceSetImpl.java:259)
	at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoadHelper(ResourceSetImpl.java:274)
	... 24 more


eclipse.buildId=4.23.0.I20220214-1800
java.version=11.0.10
java.vendor=Red Hat, Inc.
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
Command-line arguments:  -data /data/4x_platform_workspace -os linux -ws gtk -arch x86_64

org.eclipse.e4.ui.workbench
Error
Tue Feb 15 08:04:14 CET 2022
The persisted application model has no top-level window. Reinitializing with the default application model.

java.lang.Exception
	at org.eclipse.e4.ui.internal.workbench.ResourceHandler.loadMostRecentModel(ResourceHandler.java:174)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Application.loadApplicationModel(E4Application.java:371)
	at org.eclipse.e4.ui.internal.workbench.swt.E4Application.createE4Workbench(E4Application.java:247)
	at org.eclipse.ui.internal.Workbench.lambda$3(Workbench.java:573)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:338)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:551)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:156)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:152)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:136)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:596)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1467)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1440)

Comment 3 Andrey Loskutov

2022-02-15 04:00:20 EST

See /org.eclipse.swt.tools.spies/fragment.e4xmi

<persistedState key="persistState" value="false"/>

Is there any reason why these crazy e4 views must specify IWorkbench.PERSIST_STATE=false and if yes, why that is not properly implemented & destroys workbench every time? It is ridiculous!

Comment 4 Eclipse Genie

2022-02-15 04:06:44 EST

New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/190807

Comment 5 Andrey Loskutov

2022-02-15 04:09:05 EST

(In reply to Eclipse Genie from comment #4)
> New Gerrit change created:
> https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/190807

I honestly don't care why that was implemented in the way it was implemented, but with this patch it doesn't destroy the workbench anymore and is finally usable.

Thanks Rolf for layout hint.

Comment 6 Eclipse Genie

2022-02-15 04:17:56 EST

Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/190807 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=64643a9248b0ccff6efb86c7f4412692f7391354

Comment 7 Andrey Loskutov

2022-02-16 15:45:28 EST

Verified in I20220216-0600