Summary: | [GTK3] Custom cursor images are always scaled by Cairo on HiDPI displays | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Jonathan Meier <jonathan.meier> |
Component: | SWT | Assignee: | Platform-SWT-Inbox <platform-swt-inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | akurtakov |
Version: | 4.23 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
See Also: | https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/190344 | ||
Whiteboard: |
Description
Jonathan Meier
2022-02-02 16:45:00 EST
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.swt/+/190344 Please challenge my patch, in particular the native part: - Do the two new functions (gdk_cairo_surface_create_from_pixbuf and gdk_cursor_new_from_surface) actually belong into GDK.java even though they are only in GTK 3? I think they do, but there's also a few GDK functions in GTK3.java. - Are static functions excluded for GTK 4 using #define's in os.h fine or should they be dynamic? I think at least for gdk_cairo_surface_create_from_pixbuf static is the only option because GdkWindow (type of its last parameter) is no longer available on GTK 4, but gdk_cursor_new_from_surface could be dynamic without exclusion using a #define. I've tested the following combinations with and without the patch and the cursor was always small on Fedora 36 Gnome with gtk3 (3.24.31) and gtk4 (4.6.2). * gtk3/wayland * gtk3/xwayland * gtk4/wayland * gtk4/xwayland Which Gtk 3 version do you run on? Could it be some other difference like DE ? I really don't see any difference. Thanks for testing! The difference seems to be the windowing system. The issue appears when running gtk3 (3.24.30) with x11 on Ubuntu (21.10). I cannot reproduce it either using wayland on the same system. Running gtk3 (3.22.30) with x11 on CentOS (8.5) also shows the issue. On that system I can't test with wayland because I can't even get GNOME to run a wayland session. |