Bug 577275

Summary: Opened CSS Spy destroys Eclipse workbench state on next startup
Product: [Eclipse Project] PDE Reporter: Kit Lo <kitlo>
Component: UIAssignee: Lars Vogel <Lars.Vogel>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: P3 CC: Lars.Vogel, loskutov
Version: 4.22   
Target Milestone: 4.23 M1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/188092
https://bugs.eclipse.org/bugs/show_bug.cgi?id=577462
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=eafac3d983f1ac22cd03c6fcfd3ffcc597759cd5
https://bugs.eclipse.org/bugs/show_bug.cgi?id=578743
Whiteboard:
Attachments:
Description Flags
Eclipse log file none

Description Kit Lo CLA 2021-11-15 22:10:16 EST
Build ID:
I20211115-0600

Testcase:
- Launch Eclipse
- Open "Preference Spy" and "CSS Spy" views from "Window > Show View > Other... >
  Eclipse Runtime Spies" pulldown menu
- Exit Eclipse
- Launch Eclipse again
- "Preference Spy" and "CSS Spy" views do not persist in Eclipse workbench
- Found the following messages in log file:
  - Not properly disposed SWT resource
  - Unable to load resource file:.../eclipse/workspace/.metadata/.plugins
    /org.eclipse.e4.workbench/workbench.xmi
  - The persisted application model has no top-level window. Reinitializing with
    the default application model.
Comment 1 Kit Lo CLA 2021-11-15 22:11:03 EST
Created attachment 287523 [details]
Eclipse log file
Comment 2 Andrey Loskutov CLA 2021-11-24 12:43:21 EST
Preference Spy seem to be OK, but!!!

By opening CSS Spy and restarting Eclipse user looses entire workbench state.
*Everything* is gone because workbench.xmi was broken & replaced by default one!
I've just lost everything in my default SDK workspace arrrrgh!

That must be fixed.
Comment 3 Eclipse Genie CLA 2021-11-24 15:27:58 EST
New Gerrit change created: https://git.eclipse.org/r/c/pde/eclipse.pde.ui/+/188092
Comment 5 Lars Vogel CLA 2021-12-10 10:10:41 EST
.
Comment 6 Lars Vogel CLA 2021-12-13 08:19:28 EST
Validated in Eclipse SDK
Version: 2022-03 (4.23)
Build id: I20211212-1800
OS: Windows 10, v.10.0, x86_64 / win32
Java vendor: Eclipse Foundation
Java runtime version: 11.0.12+7
Java version: 11.0.12
Comment 7 Vikas Chandra CLA 2022-01-06 07:47:06 EST
Lars, can you please verify this fix?