Bug 576942

Summary:

[Dark][Win32] ToolItem hover/selection color is blue

Product:

[Eclipse Project] Platform

Reporter:

Jose Vasco <jose.vasco>

Component:

SWT

Assignee:

Platform-SWT-Inbox <platform-swt-inbox>

Status:

NEW ---

QA Contact:

Severity:

normal

Priority:

CC:

alexandr.miloslavskiy, evil_bandit_betamax, niraj.modi

Version:

4.21

Keywords:

helpwanted

Target Milestone:

---

Hardware:

OS:

Windows 10

Whiteboard:

Bug Depends on:

Bug Blocks:

577357

Attachments:

Description	Flags
ToolItem - ubuntu 20.04 vs win10 vs win11_22621.PNG	none

Description Jose Vasco

2021-10-28 12:23:22 EDT

Some of the flags that have been added to support dark theme on Windows are not working / have issues on Windows 11.

The issues I could see in particular:
- "useDarkModeExplorerTheme" - the tree items arrows are black when expanded (arrow pointing down) and on hover, the scrollbars aren't dark themed, as aren't context menus
- "Combo.useDarkTheme" - weird behavior in combos: they are not dark, get dark on hover, which makes their arrow very much disappear

Comment 1 Alexandr Miloslavskiy

2021-10-29 08:08:35 EDT

Win11 requires recent patch from Bug 576613 which is not part of released Eclipse yet. You can try an IBuild built after 2021-10-20:
https://download.eclipse.org/eclipse/downloads/

Comment 2 Jose Vasco

2021-11-12 12:16:50 EST

I can confirm the vast majority of matters have been fixed. We are still experiencing a very noticeable issue on Windows 11 dark theme though, which is the hover and selection of toolitems in toolbars being bright blue

Comment 3 Alexandr Miloslavskiy

2021-11-12 15:55:35 EST

Our product is not using toolbars, so I won't be able to allocate time to fix that, sorry.

Comment 4 Niraj Modi

2022-02-15 08:13:22 EST

(In reply to Jose Vasco from comment #2)
> I can confirm the vast majority of matters have been fixed. We are still
> experiencing a very noticeable issue on Windows 11 dark theme though, which
> is the hover and selection of toolitems in toolbars being bright blue

Issue not specific to Win11, notice same behavior on Win10 as well.

Comment 5 John Moule

2022-11-21 17:58:55 EST

Created attachment 288849 [details]
ToolItem - ubuntu 20.04 vs win10 vs win11_22621.PNG

Screengrab shows how ToolItem controls look across different platforms in dark mode:
ubuntu 20.04 vs win10 vs win11_22621
Ubuntu on LHS and Win11 on RHS.

Comment 6 John Moule

2022-11-21 17:59:52 EST

(In reply to Niraj Modi from comment #4)
> (In reply to Jose Vasco from comment #2)
> > I can confirm the vast majority of matters have been fixed. We are still
> > experiencing a very noticeable issue on Windows 11 dark theme though, which
> > is the hover and selection of toolitems in toolbars being bright blue
> 
> Issue not specific to Win11, notice same behavior on Win10 as well.

I've been checking dark theme integration in a recent Windows update (Windows11 22H2 10.0.22621).
I notice there is a very useful view for testing SWT widgets, called "SWT Controls". It is located at [1]:
I used this to show ToolItem controls. I created a screengrab [2] comparing 3 platforms, Ubuntu, Win10 and Win11, so it's easy to see the difference. Regarding the "bright blue", it seems more pronounced on Win11 now; it's bright blue rather than dark blue.
I think some hue of blue seems to be the standard way Windows shows selection/highlights. But something seems wrong here.



@Jose Vasco, is this the bug you are referring to?





[1] "SWT Controls"
eclipse.platform.swt\examples\org.eclipse.swt.examples.views\
https://github.com/eclipse-platform/eclipse.platform.swt/blob/master/examples/org.eclipse.swt.examples.views/src/org/eclipse/swt/examples/controls/ControlView.java

[2] ToolItem - ubuntu 20.04 vs win10 vs win11_22621.PNG