Bug 576751

Summary: Changing the view toolbar icons in the application model scretches the image
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: Lars.Vogel, loskutov, platform-swt-inbox, rolf.theunissen
Version: 4.22   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
Whiteboard:
Attachments:
Description Flags
Screenshot
none
Screenshot after we dynamically change the icon
none
Example project none

Description Lars Vogel CLA 2021-10-20 04:27:25 EDT
If I change the icons in the toolbar the tab height is not updated. This leads to the icon being upscaled and getting blurry.
Comment 1 Lars Vogel CLA 2021-10-20 04:29:00 EDT
Created attachment 287354 [details]
Screenshot
Comment 2 Lars Vogel CLA 2021-10-20 04:29:49 EDT
Created attachment 287355 [details]
Screenshot after we dynamically change the icon
Comment 3 Lars Vogel CLA 2021-10-20 04:31:19 EDT
Created attachment 287356 [details]
Example project

Example project. Import and call the about menu entry to trigger the icon update in the toolbar.
Comment 4 Lars Vogel CLA 2021-10-20 04:32:04 EDT
Rolf, IIRC  you already worked on a similar issue. Any idea how to fix this?
Comment 5 Lars Vogel CLA 2021-10-20 07:38:08 EDT
I actually does update the image but the image is scretched to the original size. One workaround it so remove all toolitems and add them again.
Comment 6 Andrey Loskutov CLA 2021-10-20 07:51:30 EDT
I believe this is/was SWT limitation, that all image sizes in the toolbar are aligned to the size of the first image.
Comment 7 Rolf Theunissen CLA 2021-10-20 11:22:39 EDT
Might be another regression of Bug 574641 too. The height related issue is Bug 471313.