Summary: | [JFace] add a dedicated IStyledLabelProvider interface? | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Christoph Laeubrich <laeubi> |
Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | alexander.fedorov |
Version: | 4.22 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: |
Description
Christoph Laeubrich
2021-10-15 02:42:31 EDT
@Christoph your suggestion looks good if we abstract from the surrounding code. I'm not sure why it was decided long ago to declare "DelegatingStyledCellLabelProvider.IStyledLabelProvider extends IBaseLabelProvider" and, moreover, to declare every particular I*LabelProvider to extend this IBaseLabelProvider - but this is something to consider before introducing "IStyledLabelProvider extends ILabelProvider" I would also have a look on related classes from EMF UI to understand the potential direct or "ideological" impact: `org.eclipse.emf.edit.ui.provider.AdapterFactoryLabelProvider.StyledLabelProvider` `org.eclipse.emf.common.ui.viewer.IStyledLabelDecorator` We could also add the new interface and just deprecate the embedded one with a hint that there might be an alternative for code using newer API? I just don't mind much about making the code "cleaner" but for new APIs it just sounds strange to adapt to a DelegatingStyledCellLabelProvider.IStyledLabelProvider (even though it is already used in such a way on some places). |