Bug 576043

Description Andrey ''Bass'' Shcheglov 2021-09-16 12:10:33 EDT

Created attachment 287146 [details]
Eclipse 4.7 with Raleigh GTK2 theme

I'm well aware of the `org.eclipse.swt.internal.gtk.cssFile` property, but it has the following disadvantages:

 * custom CSS rules may be theme-specific (so I may have one CSS file for Adwaita, another one for Greybird, and so on);
 * I may want to make my CSS changes an (application-specific) part of a particular theme.

For instance, for the [Raleigh-Reloaded](https://github.com/vlastavesely/raleigh-reloaded) theme, the following extra CSS changes make Eclipse look almost identically to version 4.7 with GTK2 Raleigh theme:

```
toolbar {
        border: 0;
}

scrolledwindow {
        border: 0;
}

frame {
        border: 0;
}
```

The problem with these selectors is they're way too generic and, when an integral part of a GTK theme, will negatively affect other applications.

The common solution other (well-behaved) GTK applications utilize is adding custom (application-specific) CSS styles. E. g., `thunar` (the XFCE file manager) sets the `thunar` CSS style to its top-level window, enabling a theme designer to write rules like

```
.thunar toolbar > button.flat {
        padding: 42px;
}
```

Example: https://github.com/iloveeclipse/clearlooks-phenix/blob/master/gtk-3.0/applications.css

Unfortunately, this is not possible for Eclipse.

The other aspect of the same problem is the inability to selectively apply CSS styles to Eclipse window sub-components, because they lack CSS `class` and `id` attributes, too. Consider the following sample use-cases:

 * applying a CSS selector not to a generic GtkToolbar, but to a specific one (e. g.: the main toolbar, the perspective switch toolbar, or the tool window toolbar);
 * theming the Preferences dialog differently from the main window.

The above is quite familiar for everyone with just minimal experience with Web markup, and fully possible for other GTK3 applications -- except for Eclipse.