Summary: | copy&paste java code Ui Freeze HyperlinkManager / PatternSearchJob | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Jörg Kubitz <jkubitz-eclipse> |
Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | trivial | ||
Priority: | P3 | CC: | christian.dietrich.opensource, Lars.Vogel, loskutov |
Version: | 4.20 | Keywords: | performance |
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows 10 | ||
See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=575870 | ||
Whiteboard: |
Description
Jörg Kubitz
2021-09-15 02:46:21 EDT
Shouldn't this be moved to xtext? org.eclipse.xtext.common.types.ui.navigation.LinkToOriginDetector.detectHyperlinks(LinkToOriginDetector.java:72) (In reply to Andrey Loskutov from comment #1) > Shouldn't this be moved to xtext? depends. a) jdt.core.compiler.CharOperation : jdt - maybe optimize b) jface.text.hyperlink.HyperlinkManager : platform - maybe async c) xtext.common.types.ui.navigation.LinkToOriginDetector : xtext - i got no idea for Xtext this would be a help wanted can we detect that codeSelect will have a problem and simply skip then? org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector.detectHyperlinks(ITextViewer, IRegion, boolean) seems to call the same codeSelect why wont it freeze too? (In reply to Christian Dietrich from comment #4) > org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector. > detectHyperlinks(ITextViewer, IRegion, boolean) > seems to call the same codeSelect > why wont it freeze too? i took a deeper look at the other samples. yes there are also some org.eclipse.jdt.internal.ui.javaeditor.JavaElementHyperlinkDetector.detectHyperlinks(JavaElementHyperlinkDetector.java:124) => not an xtext problem. (In reply to Jörg Kubitz from comment #2) > b) jface.text.hyperlink.HyperlinkManager : platform - maybe async This is what then need to be addressed. JDT can't guarantee instant search for any particular type, that must be done in background. moved to platform |