Bug 574444

Summary:	"No instance data can be specified" error reported in valid case
Product:	[Eclipse Project] Platform	Reporter:	Andrey Loskutov <loskutov>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	Ed.Merks, volodja_reg, wim.jongman
Version:	4.18	Keywords:	regression
Target Milestone:	---
Hardware:	PC
OS:	Linux
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=549929
Whiteboard:

Description Andrey Loskutov

2021-06-24 11:27:58 EDT

I start Oomph with workspace location @none and see this error in the log.
That is not nice, it shouldn't be shown if @none or @noDefault is specified as location.

Regression from bug 549929.


!MESSAGE Failed to get state location for bundle: org.eclipse.oomph.setup.installer_1.22.0.qualifier [135]
!STACK 0
java.lang.IllegalStateException: No instance data can be specified.
	at org.eclipse.core.internal.runtime.DataArea.assertLocationInitialized(DataArea.java:54)
	at org.eclipse.core.internal.runtime.DataArea.getStateLocation(DataArea.java:136)
	at org.eclipse.core.internal.runtime.InternalPlatform.getStateLocation(InternalPlatform.java:470)
	at org.eclipse.core.internal.runtime.InternalPlatform.getStateLocation(InternalPlatform.java:465)
	at org.eclipse.core.runtime.Platform.getStateLocation(Platform.java:1005)
	at org.eclipse.e4.ui.internal.workbench.swt.DialogSettingsProvider.getStateLocationOrNull(DialogSettingsProvider.java:203)
	at org.eclipse.e4.ui.internal.workbench.swt.DialogSettingsProvider.loadDialogSettingsFromWorkspace(DialogSettingsProvider.java:156)
	at org.eclipse.e4.ui.internal.workbench.swt.DialogSettingsProvider.loadDialogSettings(DialogSettingsProvider.java:101)
	at org.eclipse.e4.ui.internal.workbench.swt.DialogSettingsProvider.loadDialogSettings(DialogSettingsProvider.java:213)
	at org.eclipse.e4.ui.internal.workbench.swt.DialogSettingsProvider.getDialogSettings(DialogSettingsProvider.java:225)
	at org.eclipse.ui.plugin.AbstractUIPlugin.getDialogSettings(AbstractUIPlugin.java:196)
	at org.eclipse.oomph.ui.OomphUIPlugin.getDialogSettings(OomphUIPlugin.java:62)
	at org.eclipse.oomph.ui.OomphUIPlugin.getDialogSettings(OomphUIPlugin.java:67)
	at org.eclipse.oomph.setup.internal.installer.SimpleInstallerDialog.getDialogSizeSettings(SimpleInstallerDialog.java:280)
	at org.eclipse.oomph.setup.internal.installer.AbstractSimpleDialog.getDialogSize(AbstractSimpleDialog.java:254)
	at org.eclipse.oomph.setup.internal.installer.AbstractSimpleDialog.<init>(AbstractSimpleDialog.java:69)
	at org.eclipse.oomph.setup.internal.installer.SimpleInstallerDialog.<init>(SimpleInstallerDialog.java:216)
	at org.eclipse.oomph.setup.internal.installer.InstallerApplication.run(InstallerApplication.java:290)
	at org.eclipse.oomph.setup.internal.installer.InstallerApplication.start(InstallerApplication.java:397)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:203)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:401)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:654)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1462)