Bug 572128

Summary: Remove ResourcesPlugin activator
Product: [Eclipse Project] Platform Reporter: Alex Blewitt <alex.blewitt>
Component: ResourcesAssignee: Alex Blewitt <alex.blewitt>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: laeubi, Lars.Vogel, loskutov
Version: 4.20   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
See Also: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178124
https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178125
https://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=f0aa879c7613085e2951123ddb6b53841e07776c
https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178144
https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178143
https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178145
https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178147
https://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/?id=a8a8d824145ea1f309eb0b4ade83995544eead50
https://bugs.eclipse.org/bugs/show_bug.cgi?id=514333
Whiteboard:
Bug Depends on:    
Bug Blocks: 204829, 307764, 501997, 571568    

Description Alex Blewitt CLA 2021-03-19 15:36:16 EDT 
The ResourcePlugin activator does a number of things, but with careful refactoring and backwards compatible hooks, we should be able to simplify what it does.

* Register the change listener with a DS component
* Register the debug listener with a DS component
* Register the workspace with a DS component

Care needs to be taken to ensure that the movement of the Workspace doesn't cause runtime dependency/ordering issues.
Comment 1 Eclipse Genie CLA 2021-03-19 17:10:03 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178124
Comment 3 Eclipse Genie CLA 2021-03-20 13:11:48 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178144
Comment 4 Eclipse Genie CLA 2021-03-20 13:11:49 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178143
Comment 5 Eclipse Genie CLA 2021-03-20 13:11:50 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178145
Comment 6 Eclipse Genie CLA 2021-03-20 14:47:34 EDT 
New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178147
Comment 8 Lars Vogel CLA 2022-04-21 04:54:00 EDT 
Christoph, FYI. Alex already tried to use more DS in resources but faced some startup issues, see Gerrits
Comment 9 Christoph Laeubrich CLA 2022-04-21 04:56:08 EDT 
I recently provided a patch for equinox https://github.com/eclipse-equinox/equinox.framework/issues/38 that was a blocker of doing this in a seamless way and currently try to add the parts to finally make this happen without any issues.
Comment 10 Andrey Loskutov CLA 2022-04-22 14:13:50 EDT 
(In reply to Eclipse Genie from comment #7)
> Gerrit change
> https://git.eclipse.org/r/c/platform/eclipse.platform.resources/+/178144 was
> merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.resources.git/commit/
> ?id=a8a8d824145ea1f309eb0b4ade83995544eead50

For the record: this commit caused regression in 4.20, see 
https://github.com/eclipse-platform/eclipse.platform.runtime/issues/35 and bug 514333. Explanation of the problem & fix in https://github.com/eclipse-platform/eclipse.platform.runtime/pull/36
Comment 11 Lars Vogel CLA 2022-04-29 02:04:52 EDT 
Works to make the Resource plugin to use more OSGi services continues in Github