Summary: | NPE in DocumentMerge | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Rolf Theunissen <rolf.theunissen> |
Component: | Compare | Assignee: | Platform-Compare-Inbox <platform-compare-inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | Lars.Vogel, loskutov, matthias.sohn, max.gilead, platform-compare-inbox, twolf |
Version: | 4.18 | Keywords: | needinfo |
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Windows 10 | ||
Whiteboard: |
Description
Rolf Theunissen
2021-01-28 08:42:41 EST
Could be related to some egit. We need exact steps to reproduce. which version of eclipse, jgit, egit were used here ? I was just about to thank Rolf for *not* reporting this against EGit. Unlikely that this is an EGit problem. This is a strange stack trace. The TextMergeViewer is doing a diff because you saved, but from an earlier setFocus() it has still an UI job to do the diff and then tries to diff again even though a diff is already ongoing. Moreover, I don't see how there can be an NPE at DocumentMerger:451. (Could happen only if the array 'e' was null, but how could that happen?) TextMergeViewer has some logic with a fRedoDiff flag that is set to true if one side becomes non-dirty. Looks like that is not always right? It shouldn't try to do an update while an update was already in progress. I don't have exact steps to reproduce, the problem disappeared for me as well after some consistent triggering. I was editing a file with some merge conflicts. I agree with the analysis of Thomas, seems very odd issue. For completeness, EGit/JGit version: 5.10.2012080955-r (In reply to Rolf Theunissen from comment #4) > I don't have exact steps to reproduce, the problem disappeared for me as > well after some consistent triggering. I was editing a file with some merge > conflicts. > > I agree with the analysis of Thomas, seems very odd issue. > > For completeness, EGit/JGit version: 5.10.2012080955-r this version does not exist, I guess you mean 5.10.0.202012080955-r Moving back to Platform/Compare. *** Bug 571506 has been marked as a duplicate of this bug. *** See also earlier reports: bug 241107, bug 304693, bug 304941, bug 313017, bug 338541, bug 428074, bug 468726. *** Bug 304941 has been marked as a duplicate of this bug. *** |