Bug 569109

Summary: Adjust default form colors
Product: [Eclipse Project] Platform Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, Lars.Vogel, loskutov, mistria
Version: 4.17   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Screenshot of forms with theming engine disabled
none
Forms with css enabled none

Description Lars Vogel CLA 2020-11-24 04:52:15 EST
Most clients use Win10. We should adjust the default form colors to align with this. 

I mean the default colors NOT the css styling. This will affect all JFace forms clients which do not use styling but as someone recently said, "it will fix them".
Comment 1 Lars Vogel CLA 2020-11-24 04:53:03 EST
Why Win10? Because most of our users use Windows MS
Comment 2 Alexander Kurtakov CLA 2020-11-24 05:10:04 EST
If the implmentation is changed to use standard SWT colors COLOR_INFO_*, COLOR_LIST_*, COLOR_WIDGET_* ... it will look native on Win10 but also on all other WSes.
Comment 3 Lars Vogel CLA 2020-11-24 05:16:30 EST
(In reply to Alexander Kurtakov from comment #2)
> If the implmentation is changed to use standard SWT colors COLOR_INFO_*,
> COLOR_LIST_*, COLOR_WIDGET_* ... it will look native on Win10 but also on
> all other WSes.

+1
Comment 4 Mickael Istria CLA 2020-11-24 05:23:31 EST
(In reply to Alexander Kurtakov from comment #2)
> If the implmentation is changed to use standard SWT colors COLOR_INFO_*,
> COLOR_LIST_*, COLOR_WIDGET_* ... it will look native on Win10 but also on
> all other WSes.

The system theme does that already (consuming system colors for forms); but it doesn't feel that native. But I think it's more a bad choice of which system colors are picked; currently it uses the COLOR_TITLE_* variants which are shades of blue on GTK. We should probably stick to good old WIDGET_FOREGROUND (black/white) on WIDGET_BACKGROUND (grey/black) for header and titles and stop using blue.
But on a white background, nothing can feel native anyway ;)
Comment 5 Alexander Kurtakov CLA 2020-11-24 05:34:28 EST
Created attachment 284867 [details]
Screenshot of forms with theming engine disabled
Comment 6 Alexander Kurtakov CLA 2020-11-24 05:35:37 EST
(In reply to Alexander Kurtakov from comment #5)
> Created attachment 284867 [details]
> Screenshot of forms with theming engine disabled

With theming engine disabled the blue gradient color on the forms looking really alien compared to the rest of swt.
Comment 7 Andrey Loskutov CLA 2020-11-24 05:45:13 EST
Created attachment 284868 [details]
Forms with css enabled

(In reply to Alexander Kurtakov from comment #6)
> (In reply to Alexander Kurtakov from comment #5)
> > Created attachment 284867 [details]
> > Screenshot of forms with theming engine disabled
> 
> With theming engine disabled the blue gradient color on the forms looking
> really alien compared to the rest of swt.

But it looks nicer compared to css enabled, where the bluish gradient is replaced with nothing or plain gray background. 

I was not aware the forms with css looks *that* bad. Do we *really* want same for non-CSS variant, or other way around: why was it don at all this way in recent CSS changes? IMHO it is just ugly, see screenshot.
Comment 8 Mickael Istria CLA 2020-11-24 05:49:53 EST
(In reply to Andrey Loskutov from comment #7)
> But it looks nicer compared to css enabled, where the bluish gradient is
> replaced with nothing or plain gray background. 

I may be old school, but I prefer the sobriety of grey/black over the "pimpness" of blue which I find very distracting/tiring.
Comment 9 Alexander Kurtakov CLA 2021-01-07 03:07:26 EST
Mass move 4.19 M1 bugs to M3
Comment 10 Alexander Kurtakov CLA 2021-02-15 04:40:52 EST
Remove target milestone. Please set one when you start working on it.