Summary: | Adjust default form colors | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||
Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||||
Status: | NEW --- | QA Contact: | |||||||
Severity: | normal | ||||||||
Priority: | P3 | CC: | akurtakov, Lars.Vogel, loskutov, mistria | ||||||
Version: | 4.17 | ||||||||
Target Milestone: | --- | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Attachments: |
|
Description
Lars Vogel
2020-11-24 04:52:15 EST
Why Win10? Because most of our users use Windows MS If the implmentation is changed to use standard SWT colors COLOR_INFO_*, COLOR_LIST_*, COLOR_WIDGET_* ... it will look native on Win10 but also on all other WSes. (In reply to Alexander Kurtakov from comment #2) > If the implmentation is changed to use standard SWT colors COLOR_INFO_*, > COLOR_LIST_*, COLOR_WIDGET_* ... it will look native on Win10 but also on > all other WSes. +1 (In reply to Alexander Kurtakov from comment #2) > If the implmentation is changed to use standard SWT colors COLOR_INFO_*, > COLOR_LIST_*, COLOR_WIDGET_* ... it will look native on Win10 but also on > all other WSes. The system theme does that already (consuming system colors for forms); but it doesn't feel that native. But I think it's more a bad choice of which system colors are picked; currently it uses the COLOR_TITLE_* variants which are shades of blue on GTK. We should probably stick to good old WIDGET_FOREGROUND (black/white) on WIDGET_BACKGROUND (grey/black) for header and titles and stop using blue. But on a white background, nothing can feel native anyway ;) Created attachment 284867 [details]
Screenshot of forms with theming engine disabled
(In reply to Alexander Kurtakov from comment #5) > Created attachment 284867 [details] > Screenshot of forms with theming engine disabled With theming engine disabled the blue gradient color on the forms looking really alien compared to the rest of swt. Created attachment 284868 [details] Forms with css enabled (In reply to Alexander Kurtakov from comment #6) > (In reply to Alexander Kurtakov from comment #5) > > Created attachment 284867 [details] > > Screenshot of forms with theming engine disabled > > With theming engine disabled the blue gradient color on the forms looking > really alien compared to the rest of swt. But it looks nicer compared to css enabled, where the bluish gradient is replaced with nothing or plain gray background. I was not aware the forms with css looks *that* bad. Do we *really* want same for non-CSS variant, or other way around: why was it don at all this way in recent CSS changes? IMHO it is just ugly, see screenshot. (In reply to Andrey Loskutov from comment #7) > But it looks nicer compared to css enabled, where the bluish gradient is > replaced with nothing or plain gray background. I may be old school, but I prefer the sobriety of grey/black over the "pimpness" of blue which I find very distracting/tiring. Mass move 4.19 M1 bugs to M3 Remove target milestone. Please set one when you start working on it. |