Bugzilla – Full Text Bug Listing
| Summary: | "Go to last edit location" doesn't work after closing editors | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Marvin Fröhlich <eclipse> |
| Component: | UI | Assignee: | Andrey Loskutov <loskutov> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | arikast, digga1404, dzym, jonah, Lars.Vogel, loskutov, ma.becker, malaperle, mistria, yw64 |
| Version: | 4.17 | Keywords: | regression |
| Target Milestone: | 4.21 M2 | ||
| Hardware: | PC | ||
| OS: | All | ||
| See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=72773 https://bugs.eclipse.org/bugs/show_bug.cgi?id=574800 https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183341 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=cc5a9e8582f2b91e676711c33b94f440390e4149 |
||
| Whiteboard: | |||
|
Description
Marvin Fröhlich
Please provide exact steps to reproduce. The "last edit" jumps to last edit for me. Sorry, I thought, it wasn't working all the time. Because every time I used it by accident, it failed. Now I can't reproduce it intentionally. I will report back when I have a parcours. Ok, now I have some steps for you. 1. Open two classes. 2. Edit someting in class 1. 3. Edit someting in class 2. 4. Close class editor of class 2. 5. Navigate to somewhere else. 6. Hit "go to last edit location". You will end up at the last edit location on class 1, skipping that of the closed class 2. Maybe this is intentional. But it's not, what I need. And this has changed. I see it sporadically, I must confess that with the two buttons logic it is hard to understand where I'm supposed to land after using forwards / backwards. (Bug 72773 fix is very cool - not fully used to it yet) I can reproduce Comment 3. It seems that closing the editor seems to reset the location in the history to the oldest item. If I do "Next Edit Location" repeatedly after step 6 I get back to the location I expect. *** Bug 574800 has been marked as a duplicate of this bug. *** New Gerrit change created: https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183341 The original code navigated through the history backwards trying to cleanup positions on old editor document, trying to mimic old behavior. This unexpected history navigation happened also in case of multiple editors opened from the text Search, if the "reuse editors" was enabled (that is default). (In reply to Eclipse Genie from comment #7) > New Gerrit change created: > https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183341 That should not do anything on opening/closing editors and should not go backwards on re-using editors. Gerrit change https://git.eclipse.org/r/c/platform/eclipse.platform.text/+/183341 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=cc5a9e8582f2b91e676711c33b94f440390e4149 I think the patch should fix the problem now, but would be great if someone (ideally Ari / Lars) could verify if that edit navigation still works as designed. The fix is in latest SDK nightly, see https://download.eclipse.org/eclipse/downloads/drops4/I20210725-1800 Feel free to reopen if the problem isn't fixed properly. Tested with Eclipse SDK Version: 2021-09 (4.21) Build id: I20210725-1800 OS: Linux, v.5.4.0-80-generic, x86_64 / gtk 3.24.20, WebKit 2.32.0 Java vendor: AdoptOpenJDK Java runtime version: 16.0.1+9 Java version: 16.0.1 and a bunch of Asciidoc file reference for this back / forward never worked reliable and AFAICS this works fine. Also works fine for me with Java files. Thanks, Andrey. |