Bug 567248

Summary: Default form blue button is not clicked when enter pressed
Product: [Eclipse Project] Platform Reporter: Sergei Karimov <karimov_sa>
Component: SWTAssignee: Platform-SWT-Inbox <platform-swt-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: akurtakov, loskutov, paul-eclipse, platform-swt-inbox, sdamrong
Version: 4.17Keywords: regression
Target Milestone: ---   
Hardware: PC   
OS: Unix All   
Whiteboard:
Attachments:
Description Flags
screenshots none

Description Sergei Karimov CLA 2020-09-22 10:41:17 EDT
Created attachment 284224 [details]
screenshots

Steps to reproduce:
1. Open some refactoring window, for example:
Source (Alt+Shift+S)/Generate constructors from superclass (C)
2. Press Enter

Expected behaviour (was implemented in some previous eclipse version)
Default blue button (in above example "Generate") pressed, window closed.

Actual behaviour:
checkbox in constructors list unchecked
Comment 1 Andrey Loskutov CLA 2020-09-23 14:01:19 EDT
Can reproduce on RHEL 7.4 / GTK 3.22 also on 4.18 head. 
Can't reproduce on 4.16. Could be also SWT issue, but I haven't tried on Windows yet.
Comment 2 Paul Pazderski CLA 2020-09-23 14:17:51 EDT
Works as intended in I20200922-1800 on Windows 10.

But as far as I remember enter is not used to change checkbox state on Windows anyway. Only space.
Comment 3 Sergei Karimov CLA 2020-09-30 16:29:29 EDT
Yes, I've downloaded pure eclipse for windows, it's not reproduced there. will try to figure out what version causes that. I'm using STS on unix with some plugins installed.
Comment 4 Soraphol (Paul) Damrongpiriyapong CLA 2020-10-01 13:13:00 EDT
This is a regression due to a fix I made for bug 488772. There was problem was the Enter key was being handled by both the Tree and other widget, so the fix was to stop the event signal from propagating to the next widget. Reverting this fix would fix this problem but bring the other one back up. We need to find a way to fix both.
Comment 5 Alexander Kurtakov CLA 2021-08-17 13:42:20 EDT
The patch that caused it has been reverted months ago.