Bug 565121

Summary: 4diac deleting unknown types from sys file
Product: [IoT] 4DIAC Reporter: Mario Krizic <mario.krizic7>
Component: 4DIAC-IDEAssignee: Project Inbox <4diac-inbox>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: alois.zoitl
Version: 1.12.2   
Target Milestone: 2.0.1   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/180405
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/180406
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=4719dc4d121a7c6618b8909e9bd045ff4c365fe0
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/180638
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=5b2313e3fe9dd203a958d6b2ad462a8dcb7ed054
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=dcc254f7a813fbf38c2cdc4a91a2f4d2b5fc1c3a
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/181788
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=333233006afb0e41898685969fcfec4a6be6c303
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/184971
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185051
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/184965
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185085
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=c0ca76d44e04831dc36de32079c95e0ee37018f7
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185200
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=7c87565cdfe63522797c13569d368deca12bd51f
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185208
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=be55b930daf259840fbb221ab8232e64e01e035d
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/187387
https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/187507
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=5ed33df4f16e102a0823d94f7b07a51124af967a
https://git.eclipse.org/c/4diac/org.eclipse.4diac.ide.git/commit/?id=0392e7ff74470348180a1578be2acf167553820b
Whiteboard:
Attachments:
Description Flags
Import existing project into workspace none

Description Mario Krizic CLA 2020-07-10 09:15:38 EDT
When opening an application where the typelibrary is missing a custom FB it deletes the type information from the sys file. In order to restore the project correctly I need to add the missing type and then copying the old sys file from a backup or add the type information manually. It's not possible to change the type in the application so this is the only way since a system import does not include the custom types in the project library in my case (I don't know whether that is the correct behaviour). Please notify me that a type is missing and optionally let me set it to the correct one before simply deleting the information.
Comment 1 Alois Zoitl CLA 2020-07-11 07:21:26 EDT
Created attachment 283570 [details]
Import existing project into workspace
Comment 2 Alois Zoitl CLA 2020-07-11 07:21:39 EDT
Hi yes this situation is rather annoying. In the development branch we did some work to make this easier. But there is definitely more work needed here. I thought that at least the type name is preserved during saving but it looks I'm wrong here. 

But there is another point that concerns me more is how you are getting into this situation. If I read your message correctly you are using the IEC 61499 system import feature of 4diac IDE 1.12.2. Please don't use this to import existing 4diac projects. This feature is unfortunately not very reliable. Therefore we have removed it in the development branch and it will be gone from 1.13.0 on. 

If you want to import an existing 4diac IDE project please use the import existing project into workspace feature in the general import section (see attached screenshot). This will preserve all your types and project settings. And I hope it will make your live with 4diac IDE easier.
Comment 3 Mario Krizic CLA 2020-07-11 09:17:58 EDT
Hi I have tried importing using the import existing project into workspace feature, but the entire application was somehow missing in the System Explorer. 

When importing from an archive I had two projects open, one normal and the other added the suffix expanded. When I try reimporting again sometime in the near future I will provide you with screenshots.
Comment 4 Alois Zoitl CLA 2020-07-12 15:49:16 EDT
In that case I would really like to see your log file. It sounds that there is some bigger issue in your project. We did quite some fixes in the development branch to make 4diac IDE more gracefully handle such situations. But I don't think that the nightly build version of 4diac IDE is already ready for your use.
Comment 5 Eclipse Genie CLA 2021-05-10 10:19:57 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/180405
Comment 6 Eclipse Genie CLA 2021-05-10 10:23:50 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/180406
Comment 8 Eclipse Genie CLA 2021-05-16 10:04:41 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/180638
Comment 11 Eclipse Genie CLA 2021-06-10 12:05:37 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/181788
Comment 13 Eclipse Genie CLA 2021-09-03 10:29:36 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/184971
Comment 14 Eclipse Genie CLA 2021-09-06 09:05:40 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185051
Comment 15 Eclipse Genie CLA 2021-09-07 04:34:27 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185085
Comment 17 Eclipse Genie CLA 2021-09-09 04:52:28 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185200
Comment 19 Eclipse Genie CLA 2021-09-09 07:11:55 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/185208
Comment 21 Eclipse Genie CLA 2021-11-05 07:03:44 EDT
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/187387
Comment 22 Eclipse Genie CLA 2021-11-08 07:57:34 EST
New Gerrit change created: https://git.eclipse.org/r/c/4diac/org.eclipse.4diac.ide/+/187507
Comment 25 Alois Zoitl CLA 2021-12-28 09:17:55 EST
With all the work that went into error marker FBs I would close this issue for now. missing types are now preserved in applications, typed subapps and CFBs.