Bug 564645

Summary: [Mac] Switch to light theme corrupts theme in runtime workbench
Product: [Eclipse Project] Platform Reporter: Noopur Gupta <noopur_gupta>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: alexis.drogoul, Lars.Vogel, loskutov, sravankumarl
Version: 4.17   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=566043
https://bugs.eclipse.org/bugs/show_bug.cgi?id=575960
Whiteboard:
Attachments:
Description Flags
Screenshot none

Description Noopur Gupta CLA 2020-06-25 07:10:47 EDT
Created attachment 283408 [details]
Screenshot

4.17, I20200615-1800

Mac OS dark theme.

1. Launch runtime eclipse workbench (child/inner eclipse) from main Eclipse which is using light theme.
2. Switch theme of runtime eclipse to light.
3. Restart.

Even after a restart, the theme is corrupted in the runtime eclipse. See attached screenshot. 

I have tried the following JDKs to launch the runtime eclipse:
- openjdk-14_osx-x64 - corrupted
- jdk-11.0.6.jdk (oracle) - corrupted
- openjdk-11.0.2_osx-x64 - works fine
Comment 1 Noopur Gupta CLA 2020-06-30 02:49:36 EDT
I see this problem with openjdk-15-ea+28 also.
Comment 2 Noopur Gupta CLA 2020-08-26 05:34:34 EDT
Tested I20200825-1800 using jdk-11.0.6.jdk (oracle) and openjdk-15-b36. The issue is still present.
Comment 3 Sravan Kumar Lakkimsetti CLA 2020-08-26 08:05:21 EDT
Not sure whether this belongs to swt though. From the screen shot I see that the background for the image is set properly. 

@lars, Can you please help us here?
Comment 4 Lars Vogel CLA 2020-08-26 08:15:05 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #3)
> Not sure whether this belongs to swt though. From the screen shot I see that
> the background for the image is set properly. 
> 
> @lars, Can you please help us here?

Cannot reproduce on Linux.
Comment 5 Sravan Kumar Lakkimsetti CLA 2020-08-26 08:26:46 EDT
(In reply to Lars Vogel from comment #4)
> (In reply to Sravan Kumar Lakkimsetti from comment #3)
> > Not sure whether this belongs to swt though. From the screen shot I see that
> > the background for the image is set properly. 
> > 
> > @lars, Can you please help us here?
> 
> Cannot reproduce on Linux.

Ok, Do you know where the background colors are set when we change the theme?
Comment 6 Lars Vogel CLA 2020-08-26 08:33:25 EDT
(In reply to Sravan Kumar Lakkimsetti from comment #5)
> Ok, Do you know where the background colors are set when we change the theme?


Anything in the error log? Like widget is disposed? If I understand this issue correctly, this also happens with a restart of the runtime IDE. We do have a CSS handler for setting the background color, I'm currently working for a customer and cannot look it up. I can check after work tonight, if desired.
Comment 7 Sravan Kumar Lakkimsetti CLA 2020-08-26 08:51:11 EDT
Since this happens only in the runtime workbench, I consider this low priority. 

There are no errors in the console or error logs. Mostly I see issue with setting of background color. When ever you have time please let me know where I can look for css handler.
Comment 8 Lars Vogel CLA 2020-08-26 12:03:52 EDT
Sorry for the delayed response, as I said working for a client, hence I can also very restricted look into Eclipse code.

The responsible handler for setting the background color should be: org.eclipse.e4.ui.css.swt.properties.css2.CSSPropertyBackgroundSWTHandler
Comment 9 Noopur Gupta CLA 2021-06-03 07:19:49 EDT
I see the same issue with 4.20 RC2 build I20210603-0040 on using openjdk-16. 

As I work with the light theme (even while debugging in the runtime workbench), this bug does not allow me to use a JDK after openjdk-11.0.2 for launching my runtime configuration.

Any workarounds until this is fixed?
Comment 10 Alexis Drogoul CLA 2021-10-18 15:19:06 EDT
Seems like it is related to https://bugs.eclipse.org/bugs/show_bug.cgi?id=575960.
Interestingly, it also happens in an RCP app I'm developing (see https://github.com/gama-platform/gama/issues/3193).