Summary: | org.eclipse.e4.ui.css.swt.theme extension point should declare optional light/dark theme parameter | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Andrew Obuchowicz <aobuchow> |
Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | aobuchow, Lars.Vogel, pyvesdev, sw |
Version: | 4.15 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
Whiteboard: |
Description
Andrew Obuchowicz
2020-06-06 13:17:24 EDT
+1 I agree that adding an "isDark" parameter to "org.eclipse.e4.ui.css.swt.theme" would be an improvement. However, there are two places where it could be added in that extension point: * to the <theme> elements. This seems to be what you are describing, Andrew. It's a nice to have, but once a theme creator figures out that they have to include "dark" in the theme id, it won't change much for them. * to the <stylesheet> elements. This would be a real game changer in my opinion. Many Eclipse plugins contribute stylesheets to the default Eclipse Dark theme (for example https://github.com/eclipse/eclemma/blob/c648863fb19dd84a5896370573e2cf2e20969d45/org.eclipse.eclemma.ui/plugin.xml#L1065). When someone creates a new dark theme, these don't apply and they have to basically reimplement stylesheets for every single Eclipse plugin out there. For example, in Spectrum theme, Andrew has a number of commits that basically copy the stylesheet of the third-party plugin back into his own theme (for example https://github.com/AObuchow/Eclipse-Spectrum-Theme/commit/a024565d93408a04a62b409b89f30e9ff078c56e). This is a lot of work and makes creating a new dark theme very hard. If third-party plugins could contribute stylesheets for all dark themes rather than just "org.eclipse.e4.ui.css.theme.e4_dark", it would really make theming a lot easier. > * to the <stylesheet> elements. This would be a real game changer in my
> opinion. Many Eclipse plugins contribute stylesheets to the default Eclipse
> Dark theme (for example
> https://github.com/eclipse/eclemma/blob/
> c648863fb19dd84a5896370573e2cf2e20969d45/org.eclipse.eclemma.ui/plugin.
> xml#L1065). When someone creates a new dark theme, these don't apply and
> they have to basically reimplement stylesheets for every single Eclipse
> plugin out there. For example, in Spectrum theme, Andrew has a number of
> commits that basically copy the stylesheet of the third-party plugin back
> into his own theme (for example
> https://github.com/AObuchow/Eclipse-Spectrum-Theme/commit/
> a024565d93408a04a62b409b89f30e9ff078c56e). This is a lot of work and makes
> creating a new dark theme very hard. If third-party plugins could contribute
> stylesheets for all dark themes rather than just
> "org.eclipse.e4.ui.css.theme.e4_dark", it would really make theming a lot
> easier.
+1, I'm 100% for this idea, it'd give a bigger value gain to all theme creators who wish to make a dark theme. Great idea IMO!
|