Bug 563902

Summary: Unable to use use dark theme scrollbars with a theme that does not contain "dark".
Product: [Eclipse Project] Platform Reporter: Fabio Zadrozny <fabiofz>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: NEW --- QA Contact:
Severity: major    
Priority: P3 CC: daniel_megert, Lars.Vogel
Version: 4.16   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
Whiteboard:

Description Fabio Zadrozny CLA 2020-06-03 15:05:35 EDT 
It seems that DarkThemeProcessor does:

ITheme theme = (ITheme) event.getProperty("theme");
boolean isDark = theme.getId().contains("dark"); //$NON-NLS-1$
OS.setTheme (isDark);


So, it sets to use dark or not based on whether the theme name contains "dark" in its id.

This is problematic for me because I have a theme which calculates the css on demand (being dark or not) and then applies it and does the theming based on the chosen colors.

Until now this worked properly, but in 4.16rc1, I can't seem to do that anymore (having the configuration set whether the theme id has dark or not doesn't seem to work for me).

So, is there some way to disable this heuristic? (ideally, I don'w want OS.setTheme to be called at all, I just want to set the colors to match my theme).
Comment 1 Lars Vogel CLA 2020-06-04 03:27:18 EDT 
Gerrits to improve this for your use case are welcome