Bug 56284

Summary:	Test failure IWorkbenchPageTest.testCloseEditors
Product:	[Eclipse Project] Platform	Reporter:	Nick Edgar <n.a.edgar>
Component:	UI	Assignee:	Chris McLaren <csmclaren>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P2	CC:	Tod_Creasey
Version:	3.0
Target Milestone:	3.0 M8
Hardware:	PC
OS:	Windows 2000
Whiteboard:

Description Nick Edgar

2004-03-25 21:16:07 EST

The IWorkbenchPageTest.testCloseEditors is failing in the latest code from head.

Tod says:
FYI I have disabled this line in the test as Chris thinks it may now be obsolete
with todays rework and there was no point declaring a build failure this close
to the milestone before Chris got a chance to look at it.

Nick says:
I don't think the test should be disabled.  Although the isDirty check on that
line seems unrelated to the test for whether closeEditors(emptyArray) calls
doSave on the other editors, it should have been called when the editor was
opened.  This is happening correctly in other cases.  EditorPresentation.initTab
calls it when getting the initial label text.  So this indicates that opening an
editor in this case is not initializing the presentaton tab.

I'll try to dig a little further.

Comment 1 Nick Edgar

2004-03-25 21:18:24 EST

Traced through the previous openEditor.  In EditorWorkbook.add(LayoutPart),
showPart is not getting called because active==false.
It looks like this can only be false when the workbook is disposed, but it's
still the active workbook.

Comment 2 Nick Edgar

2004-03-26 00:17:25 EST

Provided a different fix for bug 55905.  The test no longer fails.