Summary: | Resolve compile warnings in JarRsrcLoader | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Karsten Thoms <karsten.thoms> |
Component: | UI | Assignee: | JDT-UI-Inbox <jdt-ui-inbox> |
Status: | NEW --- | QA Contact: | |
Severity: | trivial | ||
Priority: | P3 | CC: | stephan.herrmann |
Version: | 4.16 | ||
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://git.eclipse.org/r/162011 https://bugs.eclipse.org/bugs/show_bug.cgi?id=548309 |
||
Whiteboard: | stalebug |
Description
Karsten Thoms
2020-05-04 16:50:38 EDT
New Gerrit change created: https://git.eclipse.org/r/162011 The warnings were introduced by the upgrade to 1.6 for the jar-in-jar-loader (https://git.eclipse.org/r/#/c/144674/). I suggest you actually fix only those existing warnings :) If you want to migrate to 1.8 (as done in https://git.eclipse.org/r/#/c/162011/1/) this must be discussed here (at that point the bug would no longer be 'trivial'), and as the jenkins failures indicate, being runnable on 1.6 is actually part of the contract :) (In reply to Stephan Herrmann from comment #2) > The warnings were introduced by the upgrade to 1.6 for the jar-in-jar-loader > (https://git.eclipse.org/r/#/c/144674/). > > I suggest you actually fix only those existing warnings :) > > If you want to migrate to 1.8 (as done in > https://git.eclipse.org/r/#/c/162011/1/) this must be discussed here (at > that point the bug would no longer be 'trivial'), and as the jenkins > failures indicate, being runnable on 1.6 is actually part of the contract :) Thanks Stephan, good to know. The reason why I changed to 1.8 is that try-with-resources is not available in 1.6. But I can fix the warnings of course without using them. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |