Bug 561812

Summary:	drawBackground from CTabFolderRenderer does not check if image is not disposed
Product:	[Eclipse Project] Platform	Reporter:	Hubert Gajewski <hubert+eclipseorg>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel
Version:	4.16
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Hubert Gajewski

2020-04-06 06:51:34 EDT

This is follow up for bug 379791 (SWTException: Graphic is disposed for PlaceholderImpl).

There was missing check to be sure that image is not disposed.

Later a new code was added and the issue described in bug 379791 may occur in different place.

There is:
if (image != null)

Should be:
if (image != null && !image.isDisposed())

Comment 1 Hubert Gajewski

2020-04-06 06:53:25 EDT

Class:
CTabFolderRenderer

Method:
void drawBackground(GC gc, int[] shape, int x, int y, int width, int height, Color defaultBackground, Image image, Color[] colors, int[] percents, boolean vertical)

Comment 2 Lars Vogel

2020-04-06 07:05:35 EDT

Please provide a Gerrit for your proposed change. See https://www.vogella.com/tutorials/EclipsePlatformDevelopment/article.html#exericse-eclipse-user-creation-and-gerrit-server-configuration in case you need help with the Gerrit setup.