Bug 560668

Summary: ElementTreeSelectionDialog duplicated call to updatedStatus
Product: [Eclipse Project] Platform Reporter: Hernán González <hjgonzalez984>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: REOPENED --- QA Contact:
Severity: trivial    
Priority: P3 CC: hjgonzalez984, kalyan_prasad, Lars.Vogel
Version: 4.15   
Target Milestone: 4.24 M3   
Hardware: PC   
OS: Windows 10   
Whiteboard:

Description Hernán González CLA 2020-03-01 10:52:22 EST 
ElementTreeSelectionDialog class 
( https://github.com/eclipse/eclipse.platform.ui/blob/master/bundles/org.eclipse.ui.workbench/Eclipse%20UI/org/eclipse/ui/dialogs/ElementTreeSelectionDialog.java )
has a duplicated call in updateOKStatus() method. 


protected void updateOKStatus() {
  if (!fIsEmpty) {
    if (fValidator != null) {
      fCurrStatus = fValidator.validate(getResult());
      updateStatus(fCurrStatus);
  } else {
       // ... 
  }
  updateStatus(fCurrStatus);
}

The first updateStatus(fCurrStatus) line is redundant.
Comment 1 Eclipse Genie CLA 2022-03-03 19:10:28 EST 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 2 Lars Vogel CLA 2022-03-04 03:24:07 EST 
Could you provide a Gerrit to remove this redundant call?