Bug 559703

Summary:	Broken: warning "There are no JREs installed in the workspace that are strictly compatible with this environment"
Product:	[Eclipse Project] JDT	Reporter:	Dani Megert <daniel_megert>
Component:	Debug	Assignee:	Vikas Chandra <Vikas.Chandra>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	daniel_megert, jarthana, kalyan_prasad, manoj.palat, sarika.sinha, stephan.herrmann
Version:	4.15	Keywords:	regression
Target Milestone:	4.15 M3
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=548218 https://git.eclipse.org/r/157713 https://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=4924ffc59a70d3548ffaab13156792196bcc4bff
Whiteboard:

Description Dani Megert

2020-01-30 06:00:17 EST

Broken since 4.13.

1. Start new workspace with Java 11
2. Create a Java project where you set the execution environment to JavaSE-1.8
==> expected warning is not shown

The EE preference page correctly shows that the JRE is not strictly compatible.


Most likely caused by fix for bug 548218.

Comment 1 Stephan Herrmann

2020-01-30 06:16:45 EST

For clarification: 
- in your case do you use --release?
- where do you expect a warning?
  - in the new project wizard?
  - in the compiler properties page?
  - in the Problems view?

Comment 2 Dani Megert

2020-01-30 10:07:32 EST

(In reply to Stephan Herrmann from comment #1)
> For clarification: 
> - in your case do you use --release?
I use exactly the provided steps. By default --release is disabled.

> - where do you expect a warning?
>   - in the new project wizard?
>   - in the compiler properties page?
>   - in the Problems view?
The warning is expected on the project and hence also in the problems view.

You can try 4.12 to see how it must work.

Comment 3 Sarika Sinha

2020-01-31 01:16:58 EST

I am able to reproduce the issue.

org.eclipse.jdt.internal.launching.EECompilationParticipant.isReleaseFlagEnabled(String, String, IJavaProject) -> 
String releaseVal = project.getOption(JavaCore.COMPILER_RELEASE, true);

Returns enabled even if the the --release option is not set in the UI.

Comment 4 Sarika Sinha

2020-02-02 23:27:59 EST

Adding Manoj and Jay!

Comment 5 Sarika Sinha

2020-02-14 00:47:53 EST

Vikas has agreed to take a look from Core perspective. 
Thanks Vikas!

Comment 6 Eclipse Genie

2020-02-14 06:36:13 EST

New Gerrit change created: https://git.eclipse.org/r/157713

Comment 7 Eclipse Genie

2020-02-15 01:52:30 EST

Gerrit change https://git.eclipse.org/r/157713 was merged to [master].
Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=4924ffc59a70d3548ffaab13156792196bcc4bff

Comment 8 Sarika Sinha

2020-02-15 01:59:26 EST

Thanks Vikas and Kalyan!

Issue: There is no default value for release option for Java 8 and below so JDT core looks upward and finds --release set at Workspace level as the workspace was launched with Java 11.

Profile from OSGI does not have Release property, Launching adds this property as "Disabled" so that JDT Core does not look up in the chain.

Comment 9 Dani Megert

2020-02-16 12:59:09 EST

Verified with eclipse-SDK-I20200215-1800-win32-x86_64.

Comment 10 Dani Megert

2020-02-19 05:16:42 EST Comment hidden (obsolete)

The fix is just fixing the example scenario from comment 0 (and maybe some more).

Build: I20200218-1800.

1. Start new workspace with Java 13
2. Create a Java project where you set the execution environment to JavaSE-11
==> expected warning is not shown

The next fix needs to be tested with different combination of JRE and EE.

Comment 11 Dani Megert

2020-02-19 05:29:51 EST

(In reply to Dani Megert from comment #10)
My bad. With Java 13 we create the project with enabled --release option. Hence no warning needs to be issued.

Marked comment 10 as obsolete.