Bugzilla – Full Text Bug Listing
| Summary: | [Accessibility] Orphan content found that does not reside within a WAI-ARIA landmark or labelled region role | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Masayuki Fuse <fuse> | ||||||
| Component: | Doc | Assignee: | Lakshmi P Shanmugam <lshanmug> | ||||||
| Status: | NEW --- | QA Contact: | |||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | camle, daniel_megert, kitlo, lshanmug, niraj.modi | ||||||
| Version: | 4.15 | ||||||||
| Target Milestone: | --- | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows 10 | ||||||||
| See Also: |
https://git.eclipse.org/r/157348 https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=80fbb52cd58719c116cb221eb7869dd979b189be https://git.eclipse.org/r/157625 https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=83631414d312d7ad36d6696048528570eef6c7ca |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
Masayuki Fuse
Page : http://127.0.0.1:51721/help/advanced/tocToolbar.jsp Page : http://127.0.0.1:51721/help/advanced/tocView.jsp?view=toc Page : http://127.0.0.1:51721/help/advanced/indexToolbar.jsp Page : http://127.0.0.1:51721/help/advanced/indexView.jsp?view=index Most of the pages are different types of toolbars. Do we need to specify a landmark role for toolbars? If yes, what will be correct landmark role? role="navigation" will not be suitable for all of them. Or can we just specify the widget role, role="toolbar"? Similarly, http://127.0.0.1:51721/help/advanced/tabs.jsp provides tabs, so can we just specify role="tablist" or do we need a landmark role here? Hmm, please add landmarks respectively. Thanks New Gerrit change created: https://git.eclipse.org/r/157348 Gerrit change https://git.eclipse.org/r/157348 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=80fbb52cd58719c116cb221eb7869dd979b189be (In reply to Lakshmi Shanmugam from comment #7) > Most of the pages are different types of toolbars. Do we need to specify a > landmark role for toolbars? If yes, what will be correct landmark role? > role="navigation" will not be suitable for all of them. > Or can we just specify the widget role, role="toolbar"? > > Similarly, http://127.0.0.1:51721/help/advanced/tabs.jsp provides tabs, so > can we just specify role="tablist" or do we need a landmark role here? >> Hmm, please add landmarks respectively. Thanks I've added the tablist and toolbar roles. The jsp pages are not used as standalone pages so I think it doesn't need to have the landmark roles. If the tool still complains will, will add the landmark roles to the html page. (In reply to Masayuki Fuse from comment #8) Created attachment 281791 [details]
DAP
The error still exists and shows new violation "An interactive element/widget must have accessible name"
Created attachment 281807 [details]
DAP
Page : http://127.0.0.1:51721/help/topic/org.eclipse.help.base/doc/help_home.html, adding main looked fine. New Gerrit change created: https://git.eclipse.org/r/157625 Gerrit change https://git.eclipse.org/r/157625 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=83631414d312d7ad36d6696048528570eef6c7ca (In reply to Masayuki Fuse from comment #14) > Page : > http://127.0.0.1:51721/help/topic/org.eclipse.help.base/doc/help_home.html, > adding main looked fine. Thanks, I've made the change. (In reply to Lakshmi Shanmugam from comment #17) > (In reply to Masayuki Fuse from comment #14) > > Page : > > http://127.0.0.1:51721/help/topic/org.eclipse.help.base/doc/help_home.html, > > adding main looked fine. > > Thanks, I've made the change. Verified the fixed. Thanks. There are 9 violations on toolbar and index view. navigation role may solve some of them, however tab key and JAWS looks working fine. I'm considering to defer the fixing. (In reply to Masayuki Fuse from comment #18) > (In reply to Lakshmi Shanmugam from comment #17) > > (In reply to Masayuki Fuse from comment #14) > > > Page : > > > http://127.0.0.1:51721/help/topic/org.eclipse.help.base/doc/help_home.html, > > > adding main looked fine. > > > > Thanks, I've made the change. > > Verified the fixed. Thanks. Thanks for your help in resolving this issue. > > There are 9 violations on toolbar and index view. > navigation role may solve some of them, however tab key and JAWS looks > working fine. I'm considering to defer the fixing. I agree we should defer it. I'm not sure navigation will be the correct role for all the toolbar views in the page, such as search toolbar or bookmarks toolbar. (In reply to Lakshmi Shanmugam from comment #19) > (In reply to Masayuki Fuse from comment #18) > > (In reply to Lakshmi Shanmugam from comment #17) > > > (In reply to Masayuki Fuse from comment #14) > > > > Page : > > > > http://127.0.0.1:51721/help/topic/org.eclipse.help.base/doc/help_home.html, > > > > adding main looked fine. > > > > > > Thanks, I've made the change. > > > > Verified the fixed. Thanks. > > Thanks for your help in resolving this issue. > > > > > There are 9 violations on toolbar and index view. > > navigation role may solve some of them, however tab key and JAWS looks > > working fine. I'm considering to defer the fixing. > > I agree we should defer it. I'm not sure navigation will be the correct role > for all the toolbar views in the page, such as search toolbar or bookmarks > toolbar. okay. deferring. Thanks |