Bugzilla – Full Text Bug Listing
| Summary: | [Dark theme] Tab color settings are being ignored | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | David Vavra <davavra> | ||||||||||||||
| Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||||||||||||
| Status: | NEW --- | QA Contact: | |||||||||||||||
| Severity: | minor | ||||||||||||||||
| Priority: | P3 | CC: | aobuchow, daniel_megert, davavra, kalyan_prasad, Lars.Vogel, loskutov, mmarchand, paul-eclipse, pyvesdev | ||||||||||||||
| Version: | 4.14 | Keywords: | regression | ||||||||||||||
| Target Milestone: | --- | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 281537 [details]
Tabs in 2019-12
Lars, I believe you have optimized Dark mode in 4.14. Is this related? I don't use it, so can't say what is expected. I plan to have a look during the 4.15 time frame. Adding Pierre-Yves and Mike, which might be able to help here. Previously, the Dark theme had the following CSS for inactive tabs: swt-selected-tab-fill: '#org-eclipse-ui-workbench-INACTIVE_TAB_BG_START' '#org-eclipse-ui-workbench-INACTIVE_TAB_BG_END' 100%; And the following for active tabs: swt-selected-tab-fill: '#org-eclipse-ui-workbench-ACTIVE_TAB_BG_START' '#org-eclipse-ui-workbench-ACTIVE_TAB_BG_END' 100%; Nowadays, these are used instead: swt-selected-tab-fill: '#org-eclipse-ui-workbench-ACTIVE_TAB_BG_END'; background-color: '#org-eclipse-ui-workbench-INACTIVE_TAB_BG_END' My guess would be that this was changed to make colours in the Dark theme more consistent, but I haven't checked the entire commit history (it's quite dense and a lot has moved around/been renamed). Do things work again if you replace START with END in your preferences? 57:org.eclipse.e4.ui.css.theme.e4_dark.org.eclipse.ui.workbench.ACTIVE_TAB_BG_END=78,154,6 58:org.eclipse.e4.ui.css.theme.e4_dark.org.eclipse.ui.workbench.INACTIVE_TAB_BG_END=52,101,164 Moving to 4.16 RC1 Created attachment 283107 [details]
Tabs 2019-12 after using ACTIVE_TAB_BG_END
Sorry about the delay. Don't know how I missed the update. --- Changing ACTIVE_TAB_BG_START to ACTIVE_TAB_BG_END does alter the tab color (see attachment) but has the unexpected side-effect of outlining the tab area. Annoying but better than before. Created attachment 284225 [details]
Background after Apply
Created attachment 284226 [details]
AfterApplyAndClose
Created attachment 284227 [details]
AfterApplyAndClose
Comment on attachment 284225 [details]
Background after Apply
In both v4.16.0 and v4.17.0, the background is changed after selecting and pushing "Apply" but reverts when "Apply and Close" is pushed.
FWIW: Also changed after I took a screenshot.
Just to clarify: The line number background retains the background color selection but the text body reverts to that gray color. The "After Apply and Close" image tried setting the color to light blue. |
Created attachment 281536 [details] Tabs in 2019-09 I've been unable to change the text editor background to black in 2019-12 (v4.14) Also can't change color of Active/Inactive tabs in 2019-12 (v4.14) They remain the default colors. Works fine in 2019-09 (v4.13) I've attached an image of the tabs in 2019-09 I think they are set in <proj>/.settings/org.eclipse.ui.workbench.prefs and <proj>/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.workbench.prefs with the following settings which are identical in both 2019-12 and 2019-09: 7:ColorsAndFontsPreferencePage.selectedElement=Corg.eclipse.ui.workbench.INACTIVE_TAB_BG_START 18:de.loskutov.EclipseSkins.tab.color.active=30,144,255 19:de.loskutov.EclipseSkins.tab.color.notactive=173,216,230 57:org.eclipse.e4.ui.css.theme.e4_dark.org.eclipse.ui.workbench.ACTIVE_TAB_BG_START=78,154,6 58:org.eclipse.e4.ui.css.theme.e4_dark.org.eclipse.ui.workbench.INACTIVE_TAB_BG_START=52,101,164 80:org.eclipse.ui.workbench.ACTIVE_TAB_TEXT_COLOR=233,185,110 in <proj>/.metadata/.plugins/org.eclipse.core.runtime/.settings/org.eclipse.ui.editors.prefs the background colors are set to: 1:AbstractTextEditor.Color.Background=0,0,0 5:AbstractTextEditor.Color.SelectionForeground=0,0,0 But the 2019-12 version also has AbstractTextEditor.Color.Background.SystemDefault=false AbstractTextEditor.Color.SelectionForeground.SystemDefault=false Have the color settings moved? Does some other setting need to be set? Is something overriding them?