Summary: | [JFace] Completion proposal popup foreground color can be wrong | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Ralf Heydenreich <rheydenr> |
Component: | Text | Assignee: | Ralf Heydenreich <rheydenr> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | minor | ||
Priority: | P3 | CC: | loskutov, paul-eclipse |
Version: | 4.14 | Keywords: | ui |
Target Milestone: | 4.15 M3 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=531761 https://git.eclipse.org/r/156145 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=abb49b4ffde7627b6bc90c63d16d4da04e4b9437 |
||
Whiteboard: |
Description
Ralf Heydenreich
2020-01-13 03:52:56 EST
Yes, seems fishy. Same for CompletionProposalPopup2. Do you like to provide a change yourself [1] or is it not worth the setup for you? I'm also interested how you found it. It seems to be rare that fore- and background are retrieved from JFaceColors if no one had reported such unreadable result yet. [1] https://wiki.eclipse.org/Platform/How_to_Contribute I'll try to contribute a patch (but could take some time). I found the bug while proving the migration of Xtext to a pure E4 base. For this I've created a little example project with a very pure Xtext implementation. While showing the autocompletion the error occured. (In reply to Ralf Heydenreich from comment #2) > I'll try to contribute a patch (but could take some time). No problem. Feel free to ask if you want any help. New Gerrit change created: https://git.eclipse.org/r/156145 Gerrit change https://git.eclipse.org/r/156145 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=abb49b4ffde7627b6bc90c63d16d4da04e4b9437 Thanks Ralf! |