Bugzilla – Full Text Bug Listing
| Summary: | [gtk][Adwaita] Most of the fields in history view are empty | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Sravan Kumar Lakkimsetti <sravankumarl> | ||||||
| Component: | SWT | Assignee: | Andrey Loskutov <loskutov> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | critical | ||||||||
| Priority: | P3 | CC: | daniel_megert, Lars.Vogel, loskutov, lshanmug | ||||||
| Version: | 4.15 | Keywords: | regression | ||||||
| Target Milestone: | 4.15 M1 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: |
https://git.eclipse.org/r/154570 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9d6e19785b417802f4cf1e21fe6cc92f739d6773 https://bugs.eclipse.org/bugs/show_bug.cgi?id=553678 |
||||||||
| Whiteboard: | |||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 553678 | ||||||||
| Attachments: |
|
||||||||
Its a regression from 4.14 Which EGit version? Any errors in the log? Are you on Wayland? If you resize the view, does it work? I see *no* problems at all on RHEL 7.4 / gtk3-3.22.30 / EGit 5.7.0.201912131930 with I20191215-1800 build. There are no errors in the error log, resizing did not help and I am using x11. egit version is 5.6.0.201912041214-rc1. This is the way I tried. 1. Get Eclipse SDK 4.14 RC2 2. Install egit 5.6.0.201912041214-rc1 3. Upgrade SDK version to 4.15 (I20191212-1800) using update site http://download.eclipse.org/eclipse/updates/4.15-I-builds/ 4. Open history view. When I reported I was using my existing workspace. It is reproducible even with a new workspace (In reply to Sravan Kumar Lakkimsetti from comment #3) > There are no errors in the error log, resizing did not help and I am using > x11. > > egit version is 5.6.0.201912041214-rc1. Could you please try to update egit to latest nightly via https://download.eclipse.org/egit/updates-nightly? (In reply to Andrey Loskutov from comment #4) > (In reply to Sravan Kumar Lakkimsetti from comment #3) > > There are no errors in the error log, resizing did not help and I am using > > x11. > > > > egit version is 5.6.0.201912041214-rc1. > > Could you please try to update egit to latest nightly via > https://download.eclipse.org/egit/updates-nightly? I found this problem with with latest egit nightly build. Then I back tracked to 4.14 RC2 version. The problem exists in latest egit nightly build as well. Since this problem does not appear in 4.14 and appears in 4.15 with same egit plugin, I don't think egit is the culprit here. I think its mostly related to history view from o.e.team plugins This works fine for me using Eclipse SDK Version: 2020-03 (4.15) Build id: I20191215-1800 OS: Windows 10, v.10.0, x86_64 / win32 Java version: 14-ea So, might be an SWT issue. I assume this is SWT problem. Sravan, could you add all SWT related system properties here which you can see in Help -> About -> Installation Details -> Configuration ? Mine are: org.eclipse.swt.internal.deviceZoom=100 org.eclipse.swt.internal.gdk.backend=x11 org.eclipse.swt.internal.gtk.enableStrictChecks= org.eclipse.swt.internal.gtk.noThemingFixes= org.eclipse.swt.internal.gtk.theme=Clearlooks-Phenix org.eclipse.swt.internal.gtk.version=3.22.30 org.eclipse.swt.internal.webkitgtk.version=2.14.7 Created attachment 281241 [details]
configuration details
Here is the information requested attached is full configuration details
Here is the relevant information
org.eclipse.swt.internal.deviceZoom=100
org.eclipse.swt.internal.gdk.backend=x11
org.eclipse.swt.internal.gtk.theme=Adwaita
org.eclipse.swt.internal.gtk.version=3.22.30
(In reply to Sravan Kumar Lakkimsetti from comment #8) > Created attachment 281241 [details] > configuration details > > Here is the information requested attached is full configuration details > org.eclipse.swt.internal.gtk.theme=Adwaita That is. Can reproduce with Adwaita! Must be some color parsing regression for the theme, where my Clearlooks-Phenix is not affected. I20191204-1800 (RC2a) is OK. Going bisecting. My first candidate would be bug 553678, c1c3699c9190461b6b64f6c2672c5befd67c3f0c. (In reply to Andrey Loskutov from comment #9) > My first candidate would be > bug 553678, c1c3699c9190461b6b64f6c2672c5befd67c3f0c. Yep. That commit is first broken. (In reply to Andrey Loskutov from comment #10) > (In reply to Andrey Loskutov from comment #9) > > My first candidate would be > > bug 553678, c1c3699c9190461b6b64f6c2672c5befd67c3f0c. > > Yep. That commit is first broken. I have a fix, will push in a moment. Condition at Table, line 2973 was broken. I have to check if that happened somewhere else too. (In reply to Andrey Loskutov from comment #11) > (In reply to Andrey Loskutov from comment #10) > > (In reply to Andrey Loskutov from comment #9) > > > My first candidate would be > > > bug 553678, c1c3699c9190461b6b64f6c2672c5befd67c3f0c. > > > > Yep. That commit is first broken. > > I have a fix, will push in a moment. Condition at Table, line 2973 was > broken. I have to check if that happened somewhere else too. Table, Tree and List have similar code. Please check in all there. In background they all use gtk_tree widget New Gerrit change created: https://git.eclipse.org/r/154570 Gerrit change https://git.eclipse.org/r/154570 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9d6e19785b417802f4cf1e21fe6cc92f739d6773 Fix is merged, will resolve tomorrow after the new SDK build. *** Bug 558375 has been marked as a duplicate of this bug. *** Verified works with I20191216-1805. Verified in Eclipse SDK Version: 2020-03 (4.15) Build id: I20191216-1805 OS: Linux, v.4.15.0-72-generic, x86_64 / gtk 3.22.30 Java version: 1.8.0_222 |
Created attachment 281238 [details] History view in 4.15 Tested platform details Eclipse SDK Version: 2020-03 (4.15) Build id: I20191212-1800 OS: Linux, v.4.15.0-72-generic, x86_64 / gtk 3.22.30, WebKit 2.26.2 Java version: 1.8.0_222 The history view is showing empty columns for most of the fields. see attachment I tried same egit version on 4.14 and 4.15. This problem doesn't exist on 4.14. So I think this is not a problem with egit. Since the history view is provided by team plugins raising this under team. If not correct please change appropriately.