Bug 558281

Summary:	MenuManagerRenderer should recursively clean menus
Product:	[Eclipse Project] Platform	Reporter:	Rolf Theunissen <rolf.theunissen>
Component:	UI	Assignee:	Platform-UI-Inbox <Platform-UI-Inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	4.13
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Rolf Theunissen

2019-12-12 15:55:02 EST

When menus are added MenuManagerRenderer recursively connects MMenus to MenuManagers, however when menus are removed it seams that only the toplevel connection is removed.

Notes:
- There is a WorkbenchWindow#cleanupMenuManagerRec does recursive cleanup
- MenuManagerRenderer#unlinkMenu does recursive cleanup (only called for popups)
- MenuManagerRenderer#cleanUp does recursive cleanup of contribution records