Bug 558226

Comment 1 Lars Vogel 2019-12-11 09:35:21 EST

Fabrice, something for you?

Comment 2 Lars Vogel 2020-10-05 04:42:41 EDT

(In reply to Lars Vogel from comment #1)
> Fabrice, something for you?

Fabrice, WDYT? That would make testing and using cleanups more efficient as it would not block the normal user flow.

Comment 3 Fabrice Tiercelin 2020-10-05 05:12:14 EDT

It seems to be a good idea.

I still have a hundred of already coded cleanups to immigrate from AutoRefactor to Eclipse so I prefer migrating that first and look at this ticket then.

(so be patient :( )

Comment 4 Lars Vogel 2020-10-05 06:40:26 EDT

(In reply to Fabrice Tiercelin from comment #3)
> It seems to be a good idea.
> 
> I still have a hundred of already coded cleanups to immigrate from
> AutoRefactor to Eclipse so I prefer migrating that first and look at this
> ticket then.
> 
> (so be patient :( )

Thanks for you work. Maybe you could move the remaining cleanups as a whole? I would assume the following would work:

1.) Rename autofactoring plug-in to the jdt name space, e.g. jdt.ui.cleanups
2.) Remove already migrated and not relevant cleanups from the code base
3.) Contribute the whole refactored plug-in to JDT UI

Thanks would IMHO relatively fast compared to moving it one by one. If you have concerns about the quality you could add them to a tab "Experimental".

Comment 5 Fabrice Tiercelin 2020-10-05 08:50:34 EDT

Of course I would like to migrate all in once.

I think it would be more sensible to gather close features:
- All assertion method cleanups (JUnit, Jupiter, TestNG and AssertJ)
- Class replacement (StringBuffer -> StringBuilder, LinkedList -> ArrayList, Map -> Set...)
- For loop replacement...

I have been said not to create a gerrit greater than 1000 lines. Can I do that?

Comment 6 Lars Vogel 2020-10-05 09:34:40 EDT

(In reply to Fabrice Tiercelin from comment #5)
> Of course I would like to migrate all in once.
> 
> I think it would be more sensible to gather close features:
> - All assertion method cleanups (JUnit, Jupiter, TestNG and AssertJ)
> - Class replacement (StringBuffer -> StringBuilder, LinkedList -> ArrayList,
> Map -> Set...)
> - For loop replacement...
> 
> I have been said not to create a gerrit greater than 1000 lines. Can I do
> that?

A 1000 line contribution might result in a CQ but that is not so bad IMHO.

Comment 7 Lars Vogel 2021-03-19 14:21:01 EDT

I know I complain on a very high level as you do an amazing job Fabrice, but using and testing the cleanups would be much easier for me, if I could run them in background.

Comment 8 Eclipse Genie 2023-05-10 14:50:30 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.