Summary: | Several NPEs when compiling module declarations after 549855 | ||
---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Christoph Langer <christoph.langer> |
Component: | Core | Assignee: | Christoph Langer <christoph.langer> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | christoph.langer, daniel_megert, jarthana, jjohnstn, manoj.palat, stephan.herrmann, Vikas.Chandra |
Version: | 4.14 | Keywords: | regression |
Target Milestone: | 4.15 M1 | Flags: | manoj.palat:
review+
|
Hardware: | PC | ||
OS: | Windows 10 | ||
See Also: |
https://git.eclipse.org/r/154079 https://git.eclipse.org/r/154159 https://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=3ff9186163506e12e3283335bc32f49dad643c22 |
||
Whiteboard: |
Description
Christoph Langer
2019-12-08 17:33:42 EST
New Gerrit change created: https://git.eclipse.org/r/154079 Unfortunately RC2 has already sailed, see bug 553793. Only in cases of severe damage to life or property we could request a respin. As a workaround you may have to disable javadoc analysis in the preferences. Did you see that Vikas created bug 553564 to follow up from bug 553472 in what I called the mid-term solution? (In reply to Stephan Herrmann from comment #2) > Unfortunately RC2 has already sailed, see bug 553793. > > Only in cases of severe damage to life or property we could request a respin. > Oh, too bad. > As a workaround you may have to disable javadoc analysis in the preferences. > Did you see that Vikas created bug 553564 to follow up from bug 553472 in > what I called the mid-term solution? Ah, thanks for that hint. Maybe I can try to have a look at this. It should probably be a predecessor to further work on 548069. In any case, please have a look and check if this regression fix can be merged until we have anything better... The code change in gerrit looks good for now (we should revisit it after bug 553564 if all that will still be needed). Would you be able to also provide a test case? Jenkins build has been retriggered. (In reply to Stephan Herrmann from comment #4) > The code change in gerrit looks good for now (we should revisit it after bug > 553564 if all that will still be needed). > > Would you be able to also provide a test case? > > Jenkins build has been retriggered. I've uploaded a new patch set with a test that demonstrates the NPE if run without the fixes. The second build did not show errors.
> I've uploaded a new patch set with a test that demonstrates the NPE if run
> without the fixes.
-> that is, one of the 3 potential NPEs...
My view is that we should do a re-spin for this issue. In the current context, it would probably means joining the re-spin. Going forward, can we add test cases for all the javadocs in module-info files of openJDK? ( probably warrants another bug) New Gerrit change created: https://git.eclipse.org/r/154159 (In reply to Eclipse Genie from comment #9) > New Gerrit change created: https://git.eclipse.org/r/154159 R4_14_maintenance branch. We can put this fix in the next 4.15 I build.
>>As a workaround you may have to disable javadoc analysis in the preferences.
This can be used for 4.14
Gerrit change https://git.eclipse.org/r/154079 was merged to [master]. Commit: http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=3ff9186163506e12e3283335bc32f49dad643c22 Ideally the change in Javadoc.java should be reverted once Bug 553564 is fixed. The next I build should be usable fir OpenJDK usecase |