Bug 552714

Summary: Open Resources from Find Actions
Product: [Eclipse Project] Platform Reporter: Mickael Istria <mistria>
Component: IDEAssignee: Mickael Istria <mistria>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: julian.honnen, Lars.Vogel, loskutov
Version: 4.12Keywords: noteworthy, usability
Target Milestone: 4.14 M3   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/149982
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=95fe15b3eaeebc2913e14e9088e899a73036c6d9
https://git.eclipse.org/r/152486
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=17d05675d1c709b133194a402a5fc1d6c57f96ed
Whiteboard:
Bug Depends on: 552935    
Bug Blocks: 551494    

Description Mickael Istria CLA 2019-11-05 16:49:33 EST
List resources/files in Find Actions.
Comment 2 Julian Honnen CLA 2019-11-12 05:24:23 EST
The current implementation collects as many resources as it can within 200ms, leaving any filtering to the quick access framework.

On my workspace it manages to collect ~150k resources in that timespan, slowing down the subsequent sorting in QuickAccessProvider::getElementsSorted (takes ~10s).
Comment 3 Andrey Loskutov CLA 2019-11-12 05:28:55 EST
(In reply to Julian Honnen from comment #2)
> The current implementation collects as many resources as it can within
> 200ms, leaving any filtering to the quick access framework.
> 
> On my workspace it manages to collect ~150k resources in that timespan,
> slowing down the subsequent sorting in
> QuickAccessProvider::getElementsSorted (takes ~10s).

Same here, since some of our major customers have workspaces with over 100k files "by default", we should add UI preference to disable this feature (that one can unset via product customization), or I would vote for reverting this patch.
Comment 4 Eclipse Genie CLA 2019-11-12 06:55:08 EST
New Gerrit change created: https://git.eclipse.org/r/152486