Bug 552374

Summary: EmptyWorkspaceHelper does not refresh wizards list on perspective change
Product: [Eclipse Project] Platform Reporter: Robert Sermak <serowski>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: NEW --- QA Contact:
Severity: normal    
Priority: P3 CC: g.watson, loskutov
Version: 4.13   
Target Milestone: ---   
Hardware: PC   
OS: Windows 10   
See Also: https://git.eclipse.org/r/154780
https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=d9234748eebff16ffc9eca9b55e582f39b768757
Whiteboard:

Description Robert Sermak CLA 2019-10-24 07:25:45 EDT
Possible regression reproducible on Eclipse IDE for Java Developers 2019-09
Does not occur on earlier versions of Eclipse or at least on Eclipse IDE for Enterprise Java Developers 2019-09

After installing an extension and switching to our tool custom perspective I do not see our wizards on Package Explorer view page if there is no project in workspace. It looks like wizards are correctly registered and available from menu File -> New. Things back to normal after restarting Eclipse.

Despite the comment ('update the list of available project wizards and refresh empty area") the method EmptyWorkspaceHelper.perspectiveActivated(..) does not  update the list of available wizards to display. Once cached while Eclipse starting are present in projectWizardActions collection field until dispose() is called.

Maybe method EmptyWorkspaceHelper.recreateEmptyArea() should null projectWizardsActions to force re-read wizards? btw. there is another misleading comment, saying that the method re-reads the project wizards. 

	private void recreateEmptyArea() {
		disposeEmptyArea();

                //PROPOSED ADDITION
                projectWizardActions = null;

		// re-read the project wizards and re-create the empty area
		createEmptyArea(displayArea);
		if (control != null && !control.isDisposed()) {
			emptyArea.setBackground(control.getBackground());
		}
	}
Comment 1 Andrey Loskutov CLA 2019-10-25 11:21:16 EDT
Robert, do you want to contribute patch?
https://wiki.eclipse.org/Platform/How_to_Contribute
Comment 2 Robert Sermak CLA 2019-10-28 05:29:03 EDT
Andrey well, why not. Currently I am pretty busy, but next week I should be able to provide the patch
Comment 3 Eclipse Genie CLA 2019-12-19 04:48:31 EST
New Gerrit change created: https://git.eclipse.org/r/154780
Comment 5 Matthias Becker CLA 2020-01-24 03:21:51 EST
*** Bug 550915 has been marked as a duplicate of this bug. ***